From mboxrd@z Thu Jan 1 00:00:00 1970 From: xerofoify@gmail.com (nick) Date: Wed, 17 Sep 2014 08:19:44 -0400 Subject: A quick guide to why stand-alone checkpatch patches suck... In-Reply-To: References: <140649.1410913551@turing-police.cc.vt.edu> <153669.1410925338@turing-police.cc.vt.edu> <20140917045628.GB19159@kroah.com> <541972B5.3060403@gmail.com> <541976C6.40508@gmail.com> Message-ID: <54197C60.1000603@gmail.com> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org On 14-09-17 08:17 AM, Chris Lee wrote: >> >> Rday, >> I meant I didn't understand the code not the effect to write good solid >> patches and learn it. >> Please read my messages more carefully. >> Nick >> >> _______________________________________________ >> Kernelnewbies mailing list >> Kernelnewbies at kernelnewbies.org >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > > > Terrible reason to submit a patch. If you dont understand the code snippet, > you should not be submitting patch's against them. You need to fully > understand the code inside and out before you even consider fixing it. > > Chris > Thanks Chris, I agree with you now. I didn't mean about check patch for your information but on other parts. Thanks Nick