* [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c
@ 2014-10-21 17:34 Nicholas Krause
2014-10-22 3:31 ` Jeff Kirsher
0 siblings, 1 reply; 7+ messages in thread
From: Nicholas Krause @ 2014-10-21 17:34 UTC (permalink / raw)
To: kernelnewbies
Fix checkpatch error message with opening bracket of if statement,
not being on the same line as a if statement in rtw_ap.c
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
index 6b4092f..927b2a6 100644
--- a/drivers/staging/rtl8723au/core/rtw_ap.c
+++ b/drivers/staging/rtl8723au/core/rtw_ap.c
@@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
}
}
- if (rtw_ht_operation_update(padapter) > 0)
- {
+ if (rtw_ht_operation_update(padapter) > 0) {
update_beacon23a(padapter, WLAN_EID_HT_CAPABILITY, NULL, false);
update_beacon23a(padapter, WLAN_EID_HT_OPERATION, NULL, true);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c
2014-10-21 17:34 [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c Nicholas Krause
@ 2014-10-22 3:31 ` Jeff Kirsher
2014-10-22 4:50 ` Sudip Mukherjee
0 siblings, 1 reply; 7+ messages in thread
From: Jeff Kirsher @ 2014-10-22 3:31 UTC (permalink / raw)
To: kernelnewbies
On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
> Fix checkpatch error message with opening bracket of if statement,
> not being on the same line as a if statement in rtw_ap.c
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
I will say, it does appear you finally got a patch right. Only issue
I have is that you corrected only one of the many instances of the
same problem in this file.
If you are going to correct one instance, might as well fix them all.
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> index 6b4092f..927b2a6 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> @@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
> }
> }
>
> - if (rtw_ht_operation_update(padapter) > 0)
> - {
> + if (rtw_ht_operation_update(padapter) > 0) {
> update_beacon23a(padapter, WLAN_EID_HT_CAPABILITY, NULL, false);
> update_beacon23a(padapter, WLAN_EID_HT_OPERATION, NULL, true);
> }
> --
> 1.9.1
>
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
--
Cheers,
Jeff
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c
2014-10-22 3:31 ` Jeff Kirsher
@ 2014-10-22 4:50 ` Sudip Mukherjee
2014-10-22 5:05 ` nick
2014-10-22 5:20 ` Jeff Kirsher
0 siblings, 2 replies; 7+ messages in thread
From: Sudip Mukherjee @ 2014-10-22 4:50 UTC (permalink / raw)
To: kernelnewbies
On Tue, Oct 21, 2014 at 08:31:25PM -0700, Jeff Kirsher wrote:
> On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
> > Fix checkpatch error message with opening bracket of if statement,
> > not being on the same line as a if statement in rtw_ap.c
> >
> > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> > ---
> > drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> I will say, it does appear you finally got a patch right. Only issue
i agree to that. Finally Nick has sent a patch which is not having any style error, applies properly , doesnot change the logic.
> I have is that you corrected only one of the many instances of the
> same problem in this file.
> If you are going to correct one instance, might as well fix them all.
don't you think if he tries to fix them all at one go, he will again mess up everything ?
thanks
sudip
>
> >
> > diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> > index 6b4092f..927b2a6 100644
> > --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> > +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> > @@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
> > }
> > }
> >
> > - if (rtw_ht_operation_update(padapter) > 0)
> > - {
> > + if (rtw_ht_operation_update(padapter) > 0) {
> > update_beacon23a(padapter, WLAN_EID_HT_CAPABILITY, NULL, false);
> > update_beacon23a(padapter, WLAN_EID_HT_OPERATION, NULL, true);
> > }
> > --
> > 1.9.1
> >
> >
> > _______________________________________________
> > Kernelnewbies mailing list
> > Kernelnewbies at kernelnewbies.org
> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>
>
>
> --
> Cheers,
> Jeff
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c
2014-10-22 4:50 ` Sudip Mukherjee
@ 2014-10-22 5:05 ` nick
2014-10-22 5:25 ` Sudip Mukherjee
2014-10-22 5:28 ` Jeff Kirsher
2014-10-22 5:20 ` Jeff Kirsher
1 sibling, 2 replies; 7+ messages in thread
From: nick @ 2014-10-22 5:05 UTC (permalink / raw)
To: kernelnewbies
Good to hear, I will try tomorrow to send it a correct patch fixing out the issues like the one found
in this patch in the same file. I am pretty certain I known how to do a patch how.
Nick
On 14-10-22 12:50 AM, Sudip Mukherjee wrote:
> On Tue, Oct 21, 2014 at 08:31:25PM -0700, Jeff Kirsher wrote:
>> On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
>>> Fix checkpatch error message with opening bracket of if statement,
>>> not being on the same line as a if statement in rtw_ap.c
>>>
>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>> ---
>>> drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> I will say, it does appear you finally got a patch right. Only issue
> i agree to that. Finally Nick has sent a patch which is not having any style error, applies properly , doesnot change the logic.
>> I have is that you corrected only one of the many instances of the
>> same problem in this file.
>> If you are going to correct one instance, might as well fix them all.
> don't you think if he tries to fix them all at one go, he will again mess up everything ?
>
> thanks
> sudip
>>
>>>
>>> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
>>> index 6b4092f..927b2a6 100644
>>> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
>>> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
>>> @@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
>>> }
>>> }
>>>
>>> - if (rtw_ht_operation_update(padapter) > 0)
>>> - {
>>> + if (rtw_ht_operation_update(padapter) > 0) {
>>> update_beacon23a(padapter, WLAN_EID_HT_CAPABILITY, NULL, false);
>>> update_beacon23a(padapter, WLAN_EID_HT_OPERATION, NULL, true);
>>> }
>>> --
>>> 1.9.1
>>>
>>>
>>> _______________________________________________
>>> Kernelnewbies mailing list
>>> Kernelnewbies at kernelnewbies.org
>>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>>
>>
>>
>> --
>> Cheers,
>> Jeff
>>
>> _______________________________________________
>> Kernelnewbies mailing list
>> Kernelnewbies at kernelnewbies.org
>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c
2014-10-22 4:50 ` Sudip Mukherjee
2014-10-22 5:05 ` nick
@ 2014-10-22 5:20 ` Jeff Kirsher
1 sibling, 0 replies; 7+ messages in thread
From: Jeff Kirsher @ 2014-10-22 5:20 UTC (permalink / raw)
To: kernelnewbies
On Wed, 2014-10-22 at 10:20 +0530, Sudip Mukherjee wrote:
> On Tue, Oct 21, 2014 at 08:31:25PM -0700, Jeff Kirsher wrote:
> > On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause
> <xerofoify@gmail.com> wrote:
> > > Fix checkpatch error message with opening bracket of if statement,
> > > not being on the same line as a if statement in rtw_ap.c
> > >
> > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> > > ---
> > > drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > I will say, it does appear you finally got a patch right. Only
> issue
> i agree to that. Finally Nick has sent a patch which is not having any
> style error, applies properly , doesnot change the logic.
> > I have is that you corrected only one of the many instances of the
> > same problem in this file.
> > If you are going to correct one instance, might as well fix them
> all.
> don't you think if he tries to fix them all at one go, he will again
> mess up everything ?
Possibly... trust me, I am not jumping on the pro-nick band wagon here.
After many months of failed attempts, I am not holding my breath.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20141021/289f186a/attachment.bin
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c
2014-10-22 5:05 ` nick
@ 2014-10-22 5:25 ` Sudip Mukherjee
2014-10-22 5:28 ` Jeff Kirsher
1 sibling, 0 replies; 7+ messages in thread
From: Sudip Mukherjee @ 2014-10-22 5:25 UTC (permalink / raw)
To: kernelnewbies
On Wed, Oct 22, 2014 at 10:35 AM, nick <xerofoify@gmail.com> wrote:
> Good to hear, I will try tomorrow to send it a correct patch fixing out the issues like the one found
> in this patch in the same file. I am pretty certain I known how to do a patch how.
> Nick
just make sure that you do only kind of change in one patch. For
different types of changes , you need to send more than one patch in
series .
>
> On 14-10-22 12:50 AM, Sudip Mukherjee wrote:
>> On Tue, Oct 21, 2014 at 08:31:25PM -0700, Jeff Kirsher wrote:
>>> On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
>>>> Fix checkpatch error message with opening bracket of if statement,
>>>> not being on the same line as a if statement in rtw_ap.c
>>>>
>>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>>> ---
>>>> drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
>>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> I will say, it does appear you finally got a patch right. Only issue
>> i agree to that. Finally Nick has sent a patch which is not having any style error, applies properly , doesnot change the logic.
>>> I have is that you corrected only one of the many instances of the
>>> same problem in this file.
>>> If you are going to correct one instance, might as well fix them all.
>> don't you think if he tries to fix them all at one go, he will again mess up everything ?
>>
>> thanks
>> sudip
>>>
>>>>
>>>> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
>>>> index 6b4092f..927b2a6 100644
>>>> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
>>>> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
>>>> @@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
>>>> }
>>>> }
>>>>
>>>> - if (rtw_ht_operation_update(padapter) > 0)
>>>> - {
>>>> + if (rtw_ht_operation_update(padapter) > 0) {
>>>> update_beacon23a(padapter, WLAN_EID_HT_CAPABILITY, NULL, false);
>>>> update_beacon23a(padapter, WLAN_EID_HT_OPERATION, NULL, true);
>>>> }
>>>> --
>>>> 1.9.1
>>>>
>>>>
>>>> _______________________________________________
>>>> Kernelnewbies mailing list
>>>> Kernelnewbies at kernelnewbies.org
>>>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>>>
>>>
>>>
>>> --
>>> Cheers,
>>> Jeff
>>>
>>> _______________________________________________
>>> Kernelnewbies mailing list
>>> Kernelnewbies at kernelnewbies.org
>>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c
2014-10-22 5:05 ` nick
2014-10-22 5:25 ` Sudip Mukherjee
@ 2014-10-22 5:28 ` Jeff Kirsher
1 sibling, 0 replies; 7+ messages in thread
From: Jeff Kirsher @ 2014-10-22 5:28 UTC (permalink / raw)
To: kernelnewbies
On Wed, 2014-10-22 at 01:05 -0400, nick wrote:
> Good to hear, I will try tomorrow to send it a correct patch fixing out the issues like the one found
> in this patch in the same file. I am pretty certain I known how to do a patch how.
> Nick
Take your time Nick, please do not rush it. You have shown that when
you rush things, nothing but bad things happen.
>
> On 14-10-22 12:50 AM, Sudip Mukherjee wrote:
> > On Tue, Oct 21, 2014 at 08:31:25PM -0700, Jeff Kirsher wrote:
> >> On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
> >>> Fix checkpatch error message with opening bracket of if statement,
> >>> not being on the same line as a if statement in rtw_ap.c
> >>>
> >>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >>> ---
> >>> drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
> >>> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> I will say, it does appear you finally got a patch right. Only issue
> > i agree to that. Finally Nick has sent a patch which is not having any style error, applies properly , doesnot change the logic.
> >> I have is that you corrected only one of the many instances of the
> >> same problem in this file.
> >> If you are going to correct one instance, might as well fix them all.
> > don't you think if he tries to fix them all at one go, he will again mess up everything ?
> >
> > thanks
> > sudip
> >>
> >>>
> >>> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> >>> index 6b4092f..927b2a6 100644
> >>> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> >>> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> >>> @@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
> >>> }
> >>> }
> >>>
> >>> - if (rtw_ht_operation_update(padapter) > 0)
> >>> - {
> >>> + if (rtw_ht_operation_update(padapter) > 0) {
> >>> update_beacon23a(padapter, WLAN_EID_HT_CAPABILITY, NULL, false);
> >>> update_beacon23a(padapter, WLAN_EID_HT_OPERATION, NULL, true);
> >>> }
> >>> --
> >>> 1.9.1
> >>>
> >>>
> >>> _______________________________________________
> >>> Kernelnewbies mailing list
> >>> Kernelnewbies at kernelnewbies.org
> >>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
> >>
> >>
> >>
> >> --
> >> Cheers,
> >> Jeff
> >>
> >> _______________________________________________
> >> Kernelnewbies mailing list
> >> Kernelnewbies at kernelnewbies.org
> >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20141021/4d65de01/attachment-0001.bin
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-10-22 5:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-21 17:34 [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c Nicholas Krause
2014-10-22 3:31 ` Jeff Kirsher
2014-10-22 4:50 ` Sudip Mukherjee
2014-10-22 5:05 ` nick
2014-10-22 5:25 ` Sudip Mukherjee
2014-10-22 5:28 ` Jeff Kirsher
2014-10-22 5:20 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).