From: xerofoify@gmail.com (nick)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] staging: rtl8723au: Fix brace coding style issues reported by checkpatch
Date: Tue, 28 Oct 2014 15:52:16 -0400 [thread overview]
Message-ID: <544FF3F0.10500@gmail.com> (raw)
In-Reply-To: <CAO+WgCYKEPiiLGeAnsD26idPO0iVHK=S5E6VTtzS738eK+pZzQ@mail.gmail.com>
Hey Greg,
I am trying to improve my code as much as possible now, I really am finally understanding
how terrible my code was before and I hope never again to make patches that shitty.
Cheers Nick
On 14-10-28 02:06 PM, Greg Donald wrote:
> On Tue, Oct 28, 2014 at 12:53 PM, Nick Krause <xerofoify@gmail.com> wrote:
>> I actually fixed this to improve code readability not for the kernel
>> rules for your information.
>
> I know, good job.. and here's to hoping a maintainer picks up your
> patch and applies it to their tree :)
>
> But I would argue "kernel rules" and "improving code readability" are
> one and the same. Otherwise checkpatch and it's optional -f needn't
> exist.
>
>
next prev parent reply other threads:[~2014-10-28 19:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 19:52 [PATCH] staging: rtl8723au: Fix brace coding style issues reported by checkpatch Nicholas Krause
2014-10-28 8:24 ` Jeff Kirsher
2014-10-28 16:50 ` Greg Freemyer
2014-10-28 17:39 ` Greg Donald
2014-10-28 17:53 ` Nick Krause
2014-10-28 18:06 ` Greg Donald
2014-10-28 19:52 ` nick [this message]
2014-10-28 21:31 ` Greg Donald
2014-10-29 1:49 ` nick
2014-10-29 1:58 ` Jeff Kirsher
2014-10-29 2:01 ` nick
2014-10-29 2:04 ` Jeff Kirsher
2014-10-29 2:06 ` nick
2014-10-29 5:05 ` Sudip Mukherjee
2014-10-29 6:08 ` Scott Lovenberg
2014-10-29 6:48 ` Sudip Mukherjee
2014-10-29 8:45 ` Scott Lovenberg
2014-10-30 0:04 ` nick
2014-10-30 4:21 ` Sudip Mukherjee
2014-10-30 10:14 ` nick
2014-10-28 18:07 ` Jeff Haran
2014-10-28 18:20 ` Mandeep Sandhu
2014-10-28 20:59 ` Greg Donald
2014-10-28 18:42 ` Valdis.Kletnieks at vt.edu
2014-10-28 19:04 ` John de la Garza
2014-10-28 20:55 ` Greg Donald
2014-10-28 21:33 ` John de la Garza
-- strict thread matches above, loose matches on Subject: below --
2014-10-28 13:27 Nicholas Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544FF3F0.10500@gmail.com \
--to=xerofoify@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).