What can I do if I sent a wrong patch?

What can I do if I sent a wrong patch?

[Navy]

Hello,
A mistake was found after I sent the patch to mentors. What Can I do to make up the fault?

What can I do if I sent a wrong patch?

[Robert P. J. Day]

On Sun, 19 Jul 2015, Navy wrote:

> Hello,

> A mistake was found after I sent the patch to mentors. What Can I do
> to make up the fault?

  first, if they're truly mentors, they should check the patch
themselves and catch the error. otherwise, they're not really doing
their job as "mentors."

  second, you need to self-examine what you failed to do properly to
have sent in a bad patch.

  i doubt you've done any real harm; the linux kernel has lots of
checking up the hierarchy so that a truly damaging patch is rarely
going to get into the source tree.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

What can I do if I sent a wrong patch?

[Rik van Riel]

On 07/19/2015 05:46 AM, Robert P. J. Day wrote:
> On Sun, 19 Jul 2015, Navy wrote:
> 
>> Hello,
> 
>> A mistake was found after I sent the patch to mentors. What Can I do
>> to make up the fault?
> 
>   first, if they're truly mentors, they should check the patch
> themselves and catch the error. otherwise, they're not really doing
> their job as "mentors."
> 
>   second, you need to self-examine what you failed to do properly to
> have sent in a bad patch.

third, send out a follow-up email informing people that you found a
mistake with your patch.

People appreciate developers who take responsibility for their code,
and work to fix it up after the fact.


-- 
All rights reversed.