From mboxrd@z Thu Jan 1 00:00:00 1970 From: riel@surriel.com (Rik van Riel) Date: Sun, 19 Jul 2015 17:03:58 -0400 Subject: What can I do if I sent a wrong patch? In-Reply-To: References: <20150719094020.GA1992@debian> Message-ID: <55AC10BE.5000304@surriel.com> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org On 07/19/2015 05:46 AM, Robert P. J. Day wrote: > On Sun, 19 Jul 2015, Navy wrote: > >> Hello, > >> A mistake was found after I sent the patch to mentors. What Can I do >> to make up the fault? > > first, if they're truly mentors, they should check the patch > themselves and catch the error. otherwise, they're not really doing > their job as "mentors." > > second, you need to self-examine what you failed to do properly to > have sent in a bad patch. third, send out a follow-up email informing people that you found a mistake with your patch. People appreciate developers who take responsibility for their code, and work to fix it up after the fact. -- All rights reversed.