Trivial patches and lots of maintainers

Trivial patches and lots of maintainers

[Manuel Pégourié-Gonnard]

Hi,

When submitting trivial patches such as fixing typos in comments, should I always Cc all people suggested by get_maintainer.pl?

For example, I noticed a typo in comments in drivers/base/power/common.c for which get_maintainers.pl suggests 4 individuals plus 2 mailings lists (to which I think I should add the Trivial Patch Monkey). Intuitively, it feels wrong to personally spam 4 people for such a trivial thing. OTOH, maybe it's OK because those people are used to handle a very large volume of email anyway, and they prefer to have an opportunity to see everything, no matter how trivial.

What's the best usage here?

Thanks,
Manuel.

Trivial patches and lots of maintainers

[Peter Senna Tschudin]

Hello Manuel,

On Mon, Dec 28, 2015 at 4:08 PM, Manuel P?gouri?-Gonnard <mpg@elzevir.fr> wrote:
> Hi,
>
> When submitting trivial patches such as fixing typos in comments, should I always Cc all people suggested by get_maintainer.pl?
Sending to everyone pointed by get_maintainer.pl is usually a good idea.

>
> For example, I noticed a typo in comments in drivers/base/power/common.c for which get_maintainers.pl suggests 4 individuals plus 2 mailings lists (to which I think I should add the Trivial Patch Monkey). Intuitively, it feels wrong to personally spam 4 people for such a trivial thing. OTOH, maybe it's OK because those people are used to handle a very large volume of email anyway, and they prefer to have an opportunity to see everything, no matter how trivial.

There is no rule, but a good starting point is the log of the file you
plan to change.

$ git log drivers/base/power/common.c

As the history doesn't show many trivial patches, maybe there are
other files that are more likely to be a good starting point(I'm
assuming you are starting sending patches to Linux).

>
> What's the best usage here?
I think that you can start in files from drivers/staging, as there is
usually work to be done there.


Good luck!

Trivial patches and lots of maintainers

[Manuel Pégourié-Gonnard]

On 28/12/2015 20:42, Peter Senna Tschudin wrote:
> On Mon, Dec 28, 2015 at 4:08 PM, Manuel P?gouri?-Gonnard <mpg@elzevir.fr> wrote:
>> When submitting trivial patches such as fixing typos in comments,
>> should I always Cc all people suggested by get_maintainer.pl?
> Sending to everyone pointed by get_maintainer.pl is usually a good
> idea.
> 
Ok, I'll do that then.

>> What's the best usage here?
> I think that you can start in files from drivers/staging, as there is
> usually work to be done there.
> 
Yes, that's what I'm doing but in the process I often end up reading
other parts of the source (which I guess is one of the expected positive
side-effects), so sometimes I can notice minor things to fix outside
staging.

> Good luck!
> 
Thanks!

Manuel.