From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AAFFC433DF for ; Sat, 8 Aug 2020 19:58:25 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2621E206C3 for ; Sat, 8 Aug 2020 19:58:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=vt-edu.20150623.gappssmtp.com header.i=@vt-edu.20150623.gappssmtp.com header.b="o0OydkNQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2621E206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vt.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94) (envelope-from ) id 1k4UyY-0007rA-SC; Sat, 08 Aug 2020 15:57:54 -0400 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1k4UyW-0007r4-Kt for kernelnewbies@kernelnewbies.org; Sat, 08 Aug 2020 15:57:52 -0400 Received: by mail-qt1-x835.google.com with SMTP id w9so3898022qts.6 for ; Sat, 08 Aug 2020 12:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vt-edu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:in-reply-to:references:mime-version :content-transfer-encoding:date:message-id; bh=T100n/1/+l1K5rwTGoR9YtZqbjt66Oj+8wD74P2gLL4=; b=o0OydkNQoajYX8VhcN7P1/lt90nLTkOA8TMKHklXht+Xm+8Zj/CQ4yrnSbVn8cGYjt ZiFy+/7inPNJJmoJqEG0nUFPi2oR+N7wYk1w/8RWtrv/B9+rfHFfmkalX/oXAtPmQkmF 5qoi4oQJH2KOQkVN/iJfK1avBA87DvWGD1q5JMGHWgAG7VvoVePERAxGFCrglRM4RrVQ ogrKPkLP4ex0R18Cy/ldBzJljWf9/k48JGLqJ4CjXgYoAwwp6w6zbvqQ1NmoKuNpsO6z AQr3N/lCia8hhu92T6SFm8qS0sT8Nv93ZhxB3cvVdD9K3FcEWL0M+q6u8kKjyCrcG3F7 89Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:content-transfer-encoding:date:message-id; bh=T100n/1/+l1K5rwTGoR9YtZqbjt66Oj+8wD74P2gLL4=; b=Cuxo6eJAFvLsSmN6cK21URvuE1YR9cNwo5NQJFxMO4JmGnlXV5o98ymcHbx/mryFDt mw07EPlzx8yiIWDnKcnMMHGlrFjPefS0LyYzSgXqB/7UB5z1HQTsHVqpHdsrBpjwxiAN TFMkFrazwAMsezdw2bTR7jzFUDGyUiFlSpxJWZs2CkXNAz8GoAd1GfWIlPRwBhGVEK3z 5Y0XWdpNG2bsqaAbYt3EvoO/mUKXlRM317ErfndKrvWhPc9R7rQ51JeqcW3rQ0NKWqt1 bnaQlxeWSg0FelEKYZocnhHNPXNanZD6H4dt52DtXq+ge3ft/6h5IcdJ8BZKNTyW5y5I J7Jg== X-Gm-Message-State: AOAM532GGzGgCum+/iyeUJ5+WRji29Gs8CAq0JA6gCiy7HoZB5fi/JcE cBVnqyoZ7P22aiflIC+dFNmJ5w== X-Google-Smtp-Source: ABdhPJzXbpffkRish2i/jLW674wPrcS/Vn6CH7gn2eljs9Ws9zumOMLW8UXB4ssN7+hWYBseTYV9Yw== X-Received: by 2002:ac8:306a:: with SMTP id g39mr20439367qte.259.1596916610981; Sat, 08 Aug 2020 12:56:50 -0700 (PDT) Received: from turing-police ([2601:5c0:c000:a8c1::359]) by smtp.gmail.com with ESMTPSA id d46sm12057096qtk.37.2020.08.08.12.56.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2020 12:56:49 -0700 (PDT) From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: cristian andres vargas gonzalez Subject: Re: functions with empty body in file /kernel/events/core In-Reply-To: <122F362A-07B8-41C0-BAAA-A7ED15405361@hxcore.ol> References: <122F362A-07B8-41C0-BAAA-A7ED15405361@hxcore.ol> Mime-Version: 1.0 Date: Sat, 08 Aug 2020 15:56:49 -0400 Message-ID: <57068.1596916609@turing-police> Cc: "kernelnewbies@kernelnewbies.org" X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4443558318564099892==" Errors-To: kernelnewbies-bounces@kernelnewbies.org --===============4443558318564099892== Content-Type: multipart/signed; boundary="==_Exmh_1596916608_13801P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --==_Exmh_1596916608_13801P Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, 08 Aug 2020 12:48:08 -0500, cristian andres vargas gonzalez said:= > Who have an empty body, Which is a reasonable thing to have, if the function doesn't do anything = on a given architecture or configuration. > I understand that they are inside a conditional created by the preproce= ssor > directives and also that they are called in some parts of the code , bu= t would > it really be necessary that when the directive is not true to leave the= > function with the body empty, would it be a solution? I admit being confoozled here - would leaving a function with an empty bo= dy be a solution? Obviously it *would* be one, because the kernel currently doe= s that. > Or is it just missing to eliminate those functions without a body? Feel free to try it and see what happens. :) (Make sure to try two differ= ent configs, one that includes the version that has the non-empty body, and one that tries to call the eliminated function without a body). --==_Exmh_1596916608_13801P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQIVAwUBXy8DgAdmEQWDXROgAQL1dQ//arGhIuSP7QyjOofVCgpwJTu5tfq/0yTJ rkRWJvtSoRxr6biC00N+AgNgSc755cipJaHDAIq7xRrq9tHUQOqFBUvZYZRr20xn VL2n3x3uR2rffU5TSfHyizV9AhCxafkyoC49XlLbeTIxidubswtSfOpDyiuupSVu 2p+eaf+wo51EHt2i/NiSuET6lomWU418uZuOuoddUaTy7mlbbwZQPL3HXrlP5gNC QtMBcYTO2lIbGi8Nk7g1i+SPNQJs76FBqmAcZwQeelw8vMkL5rNsdHfVkw5fyDBA gEKBvJjcVTpWUd8BGyNaYBu7F5cDopyYXIfCfgIUdcs/HBkTaL0cv3M3QbQaXgMS z9RElA1j5rD6dv8Bw1pPA6pbXr3ATA6W1Ep/Rbz7BnOevGIuRH4H/eSVvyEjKCDP 3scYIOTHm5UIjw4WTJrZMUwJnvmfG8nZUQy4LXCELiH4JXHAAGFTQhMAaIXRN3W6 ulswVGYow7qqnv+S9zWIEhk3ukIj7xEmh/HgheBVvW4Z2OM0DVRD4rqqEUC10+DQ ssy7F5BII38gO7dnDngyKg60/G3OyWZs2OVTI30MB848wekx8sCCROTyDOQQ0NKV E7OASV/yM6Msf5MssUgAEqkkpOxkdWNyU2NgMCtCUdxFGbrwmthd8BEf1k9qJ78E 4D5polBbY/A= =vi76 -----END PGP SIGNATURE----- --==_Exmh_1596916608_13801P-- --===============4443558318564099892== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies --===============4443558318564099892==--