From: Valdis.Kletnieks@vt.edu (Valdis.Kletnieks at vt.edu)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Submitted a first patch and no reply
Date: Thu, 08 Jan 2015 15:49:27 -0500 [thread overview]
Message-ID: <79493.1420750167@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Thu, 08 Jan 2015 12:37:15 -0800." <CAG77vrrp-N9-C4cCmLr6p_fVM_bRwYni5-ixuOry+qE7opeU3A@mail.gmail.com>
On Thu, 08 Jan 2015 12:37:15 -0800, shirish gajera said:
> That's hwy I just fix one warning.
That means "don't fix a warning about indentation *and* a warning
about trailing blanks in the same patch".
Also, if you're fixing a style issue, you should actually *review* the
code, and make sure you fix the issue everywhere, *even if the other ones
didn't prompt a warning*.
It's interesting that the warning only popped on the one case where the
"/* looping version */" is on a separate line, not on the #else line.
Am cc'ing Joe Perches for that question. Joe - to get you up to speed,
checkpatch was run against drivers/staging/skein/skein_block.c, and it
flagged one definition of the macro R256, but not the other one, or the
two definitions each for R512 and R1024. Any idea why?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20150108/aee60739/attachment.bin
next prev parent reply other threads:[~2015-01-08 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 20:00 Submitted a first patch and no reply shirish gajera
2015-01-08 20:32 ` Valdis.Kletnieks at vt.edu
2015-01-08 20:37 ` shirish gajera
2015-01-08 20:49 ` Valdis.Kletnieks at vt.edu [this message]
2015-01-08 21:14 ` Joe Perches
2015-01-08 21:25 ` shirish gajera
2015-01-08 21:31 ` [PATCH] checkpatch: Allow comments in macros tested for single statements Joe Perches
2015-01-09 16:55 ` Submitted a first patch and no reply michi1 at michaelblizek.twilightparadox.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79493.1420750167@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).