kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: bjorn@mork.no (Bjørn Mork)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Understanding get_maintainer.pl and MAINTAINERS
Date: Thu, 09 Mar 2017 10:22:06 +0100	[thread overview]
Message-ID: <871su6vm81.fsf@miraculix.mork.no> (raw)
In-Reply-To: <87d1dqvpdx.fsf@miraculix.mork.no> ("Bjørn Mork"'s message of "Thu, 09 Mar 2017 09:13:46 +0100")

Bj?rn Mork <bjorn@mork.no> writes:

> The N entries are regex patterns.  "bcm281*" matches any name starting
> with "bcm28", followed by 0 or more 1's.

This isn't entirely correct. I assumed there was some implicit anchoring
on path name components, but there isnt. So "bcm281*" will match any
file containing "bcm28" somewhere in the path.

I am obviously not the first one making that bogus assumption. Very few
of the "N:" entries in MAINTAINERS are anchored in any way.  The rest of
them are likely buggy.  No one expects these strings to match in the
middle of arbitrary path names.  Even the example is a bit too wild
IMHO:

        N: Files and directories with regex patterns.
           N:   [^a-z]tegra     all files whose path contains the word tegra

The '[^a-z]' prevents this from matching any word containing "tegra".
But it will still match e.g "INtegrator" or "b1tegrasp", which is
unexpected.  It would be better to use a more explicit anchor, like
'[-/]tegra'.  Or maybe even "/tegra".




Bj?rn

  reply	other threads:[~2017-03-09  9:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 23:08 Understanding get_maintainer.pl and MAINTAINERS Robin Krahl
2017-03-09  8:13 ` Bjørn Mork
2017-03-09  9:22   ` Bjørn Mork [this message]
2017-03-09 19:03   ` Robin Krahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871su6vm81.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).