From: bjorn@mork.no (Bjørn Mork)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] net: ethernet: clean out braces / old code (found via checkpatch)
Date: Thu, 04 Oct 2012 20:54:29 +0200 [thread overview]
Message-ID: <87lifmf4pm.fsf@nemi.mork.no> (raw)
In-Reply-To: <CADLW2vyL01M8jYQDxXLJUrAYbJ=+APZagDb6b90akiThoqdQcA@mail.gmail.com> (Matthew Walster's message of "Thu, 4 Oct 2012 17:13:27 +0100")
Matthew Walster <matthew@walster.org> writes:
> On 3 October 2012 14:12, Scott Lovenberg <scott.lovenberg@gmail.com> wrote:
>
>> Sorry, man. I'm not going to mix it up with Dave Miller, but really
>> if he wanted that to stay in there a comment suggesting so would have
>> been nice.
>>
>
> I have a thick skin, don't worry! I figured I was being helpful, clearly I
> caught him either at a bad time or he's just had a rash of semi-ignorant
> checkpatch-monkeys submitting and he's fed up with us!
Please note that despite the direct tone, the reply you got
a) was prompt,
b) explained why the patch was rejected,
c) contained additional advice on how to proceed
You will learn to appreciate these things after a while. The "net"
subsystem is one of the best places to send a patch, just because of the
three points above. I am not saying that there aren't other subsystems
which are equally well maintained. There sure are. But the "net"
subsystem is definitely among the best, and that makes it easy to work
with for us new patch submitters.
The absolute worst thing that could have happened would have been no
answer at all, right?
Bj?rn
next prev parent reply other threads:[~2012-10-04 18:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 10:56 Advice on first patch matthew at walster.org
2012-10-02 10:56 ` [PATCH] net: ethernet: clean out braces / old code (found via checkpatch) matthew at walster.org
2012-10-02 16:16 ` Scott Lovenberg
2012-10-03 9:13 ` Matthew Walster
2012-10-03 13:12 ` Scott Lovenberg
2012-10-04 16:13 ` Matthew Walster
2012-10-04 18:54 ` Bjørn Mork [this message]
2012-10-02 11:29 ` Advice on first patch Bjørn Mork
2012-10-02 11:34 ` Matthew Walster
2012-10-03 9:25 ` Bjørn Mork
2012-10-03 13:40 ` Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lifmf4pm.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).