From mboxrd@z Thu Jan 1 00:00:00 1970 From: bjorn@mork.no (=?utf-8?Q?Bj=C3=B8rn_Mork?=) Date: Thu, 04 Oct 2012 20:54:29 +0200 Subject: [PATCH] net: ethernet: clean out braces / old code (found via checkpatch) In-Reply-To: (Matthew Walster's message of "Thu, 4 Oct 2012 17:13:27 +0100") References: <1349175364-21936-1-git-send-email-matthew@walster.org> <1349175364-21936-2-git-send-email-matthew@walster.org> Message-ID: <87lifmf4pm.fsf@nemi.mork.no> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org Matthew Walster writes: > On 3 October 2012 14:12, Scott Lovenberg wrote: > >> Sorry, man. I'm not going to mix it up with Dave Miller, but really >> if he wanted that to stay in there a comment suggesting so would have >> been nice. >> > > I have a thick skin, don't worry! I figured I was being helpful, clearly I > caught him either at a bad time or he's just had a rash of semi-ignorant > checkpatch-monkeys submitting and he's fed up with us! Please note that despite the direct tone, the reply you got a) was prompt, b) explained why the patch was rejected, c) contained additional advice on how to proceed You will learn to appreciate these things after a while. The "net" subsystem is one of the best places to send a patch, just because of the three points above. I am not saying that there aren't other subsystems which are equally well maintained. There sure are. But the "net" subsystem is definitely among the best, and that makes it easy to work with for us new patch submitters. The absolute worst thing that could have happened would have been no answer at all, right? Bj?rn