kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg KH <greg@kroah.com>, Ian Pilcher <arequipeno@gmail.com>
Cc: kernelnewbies@kernelnewbies.org
Subject: Re: When reviewers stop responding
Date: Wed, 22 Jun 2022 06:20:04 +0200	[thread overview]
Message-ID: <9fa37c18-e6a1-f33d-3f58-1bd4490fe767@gmail.com> (raw)
In-Reply-To: <Yp+JgU2tbb50sHhk@kroah.com>

On 6/7/22 19:23, Greg KH wrote:
> And again, please help review code, otherwise you are just asking others
> to do work for you, which if you think about it, could be construed as a
> bit selfish, and I don't think you mean it to be.

Hi Greg,

this applies to me. I promise to improve. But this topic is not enough 
advertised. Everywhere information about patches can be found. But how 
to do a correct Reviewed-by: or Tested-by: is not so good documented.

I bought hardware to improve and did one "Tested-by:" of the patch:

[PATCH v2 0/5] Fixed some coding style issues and spelling
from Chang Yu <marcus.yu.56@gmail.com>

https://lore.kernel.org/linux-staging/91c9a0de-76f8-37fb-31b4-4401a6e35d48@gmail.com/T/#t

Did I do something wrong or was I just unlucky?

Is 24 hours quick enough response?

Thanks for your support.

Bye Philipp








_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

  reply	other threads:[~2022-06-22  4:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18 19:55 When reviewers stop responding Ian Pilcher
2021-11-19  7:08 ` Greg KH
2022-06-07 17:19   ` Ian Pilcher
2022-06-07 17:23     ` Greg KH
2022-06-22  4:20       ` Philipp Hortmann [this message]
2022-06-22  9:34         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fa37c18-e6a1-f33d-3f58-1bd4490fe767@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=arequipeno@gmail.com \
    --cc=greg@kroah.com \
    --cc=kernelnewbies@kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).