From: spinlock.cp@gmail.com (spinlock cp)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Regarding threaded irq
Date: Tue, 1 Mar 2011 10:41:12 +0530 [thread overview]
Message-ID: <AANLkTikV-HC8Me6Rh4Z5=VDfZoBcva5Ws5OAv-9wbirn@mail.gmail.com> (raw)
In-Reply-To: <AANLkTin9Q=8hDN6F2BcVpns0BJH9xpPX_i74X=OQ+oF+@mail.gmail.com>
Hi Anish
On Mon, Feb 28, 2011 at 5:53 PM, anish singh <anish198519851985@gmail.com>wrote:
> I have a touch driver which is not yet using threded_irq.So i am planning
> to change it to
> use threaded_irq.
>
> In the current handler they are first disabling the irq line and then
> calling the single threaded
> workqueue to do the rest of the task and when the task is completed i.e. in
> the end of workqueue
> function they are enabling the irq line.
>
>
> So my question is if i change it to use threaded_irq.In the handler should
> i also enable or disable
> the irq as is done in the case of present handler OR i don't need to do
> this step?
> ---i think IRQF_ONESHOT will do this for me right?
>
There could be a very good reason, why IRQ were disabled at entry and
re-enabled at exit in workqueue.
For example if, workqueue is acquiring the spinlock and which is expected
to be acquired by ISR also.
Probably you should reason why irq were disabled/enabled in work queue and
redesign your threded_irq accordingly
> I want this threaded handler to be executing as soon as possible as i want
> the latency between the
> touch by the user and response to be minimum.Is there any way to achieve
> this?
>
> FYI... handler contains some I2C transfer + reporting co-ordinates to Input
> core.
>
> Does the above usecase justify changing to threaded_irq??
>
>
>
>
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>
>
Regards
Spinlock
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20110301/63ff7925/attachment.html
next prev parent reply other threads:[~2011-03-01 5:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 12:23 Regarding threaded irq anish singh
2011-03-01 5:11 ` spinlock cp [this message]
2011-03-01 5:19 ` anish singh
2011-03-03 13:41 ` Thomas Petazzoni
2011-03-04 5:32 ` anish singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikV-HC8Me6Rh4Z5=VDfZoBcva5Ws5OAv-9wbirn@mail.gmail.com' \
--to=spinlock.cp@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).