From: martinez.javier@gmail.com (Javier Martinez Canillas)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH 3/5] tg3: Enclose macro with complex values in parenthesis
Date: Thu, 3 Mar 2011 12:54:52 +0100 [thread overview]
Message-ID: <AANLkTinjaRMUgr_N4v_63ExrqJsU_i47Q3_xwQQN9CiA@mail.gmail.com> (raw)
In-Reply-To: <20110302.205601.71129255.davem@davemloft.net>
>
> This seems unnecessary, what problem do the current macro definitions
> create?
>
Probably the change is unnecessary, the only value is that it silences
a checkpatch error:
ERROR: Macros with complex values should be enclosed in parenthesis
Sorry for the noise.
--
-----------------------------------------
Javier Mart?nez Canillas
(+34) 682 39 81 69
PhD Student in High Performance Computing
Computer Architecture and Operating System Department (CAOS)
Universitat Aut?noma de Barcelona
Barcelona, Spain
next prev parent reply other threads:[~2011-03-03 11:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 17:04 [PATCH 1/5] tg3: use <linux/io.h> and <linux/uaccess.h> instead <asm/io.h> and <asm/uaccess.h> Javier Martinez Canillas
2011-03-01 17:04 ` [PATCH 1/5] tg3: use usleep_range not msleep for small sleeps Javier Martinez Canillas
[not found] ` <20110302.205536.226759949.davem@davemloft.net>
2011-03-03 12:14 ` Javier Martinez Canillas
2011-03-01 17:04 ` [PATCH 3/5] tg3: Enclose macro with complex values in parenthesis Javier Martinez Canillas
[not found] ` <20110302.205601.71129255.davem@davemloft.net>
2011-03-03 11:54 ` Javier Martinez Canillas [this message]
2011-03-01 17:04 ` [PATCH 4/5] tg3: Don't use IRQF_SAMPLE_RANDOM Javier Martinez Canillas
2011-03-01 17:04 ` [PATCH 5/5] tg3: Fix inline keyword usage Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinjaRMUgr_N4v_63ExrqJsU_i47Q3_xwQQN9CiA@mail.gmail.com \
--to=martinez.javier@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).