kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: anish198519851985@gmail.com (Anish Kumar)
To: kernelnewbies@lists.kernelnewbies.org
Subject: I have a large patch in the 2000 lines. What to do?
Date: Fri, 9 Oct 2015 12:12:44 -0700	[thread overview]
Message-ID: <AD20A93C-563F-49A1-905C-397299ABB584@gmail.com> (raw)
In-Reply-To: <56180B3F.9040208@gmail.com>



> On Oct 9, 2015, at 11:45 AM, Ivan Safonov <insafonov@gmail.com> wrote:
> 
> Hi!
> 
> I have a large patch in the 2000 lines, which replaces the macro BITn to 
> BIT(n) in multiple files.

I will recommend sending RFC patch first and 
Get the community comments.

If they like your patch then divide the patch based on logic rather than lines of codes.
> Is it worth to split this patch into several parts?
> Is it sufficient to place the changes in each file in a separate part of 
> patchset?
> 
> 
> 
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

  reply	other threads:[~2015-10-09 19:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09 18:45 I have a large patch in the 2000 lines. What to do? Ivan Safonov
2015-10-09 19:12 ` Anish Kumar [this message]
2015-10-09 19:20   ` Greg KH
2015-10-10  1:02     ` Ivan Safonov
2015-10-10 14:14       ` Greg KH
2015-10-16 21:14         ` Julio Faracco
2015-10-16 21:31           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AD20A93C-563F-49A1-905C-397299ABB584@gmail.com \
    --to=anish198519851985@gmail.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).