From: srishtishar@gmail.com (srishti sharma)
To: kernelnewbies@lists.kernelnewbies.org
Subject: driver todo's
Date: Sat, 11 Feb 2017 11:50:19 +0530 [thread overview]
Message-ID: <CAB3L5ox668EG48A2vbZPnhUepkd59mVaukwdaKhmTZmqeipfPg@mail.gmail.com> (raw)
In-Reply-To: <20170204082024.GA29629@kroah.com>
Hey , I have posted my first patch . Will I be notified if it gets accepted ?
Regards
Srishti
On Sat, Feb 4, 2017 at 1:50 PM, Greg KH <greg@kroah.com> wrote:
> On Sat, Feb 04, 2017 at 04:20:53AM +0530, srishti sharma wrote:
>> I got this warning for a structure to be defined as constant , I have
>> fixed it by adding const , now this variable is not being used in this
>> file , so I was wondering if I should fix such warnings ? What if this
>> variable is used in some other file and the developer didn't want it
>> to be constant despite it producing a warning ? Maybe I am wrong .
>
> I have no idea what you are talking about, you are going to have to be a
> lot more specific, or even better yet, post your patch.
>
> But remember, you can only do "one thing" per patch, so don't try to do
> multiple things at the same time. Use a series of patches for that.
>
> good luck!
>
> greg k-h
next prev parent reply other threads:[~2017-02-11 6:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 22:06 driver todo's srishti sharma
2017-02-03 22:39 ` Greg KH
2017-02-03 22:50 ` srishti sharma
2017-02-04 8:20 ` Greg KH
2017-02-11 6:20 ` srishti sharma [this message]
2017-02-11 7:21 ` Greg KH
2017-02-11 8:04 ` srishti sharma
2017-02-14 15:15 ` Anuz Pratap Singh Tomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB3L5ox668EG48A2vbZPnhUepkd59mVaukwdaKhmTZmqeipfPg@mail.gmail.com \
--to=srishtishar@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).