From mboxrd@z Thu Jan 1 00:00:00 1970 From: srishtishar@gmail.com (srishti sharma) Date: Sat, 11 Feb 2017 11:50:19 +0530 Subject: driver todo's In-Reply-To: <20170204082024.GA29629@kroah.com> References: <20170203223949.GA29934@kroah.com> <20170204082024.GA29629@kroah.com> Message-ID: To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org Hey , I have posted my first patch . Will I be notified if it gets accepted ? Regards Srishti On Sat, Feb 4, 2017 at 1:50 PM, Greg KH wrote: > On Sat, Feb 04, 2017 at 04:20:53AM +0530, srishti sharma wrote: >> I got this warning for a structure to be defined as constant , I have >> fixed it by adding const , now this variable is not being used in this >> file , so I was wondering if I should fix such warnings ? What if this >> variable is used in some other file and the developer didn't want it >> to be constant despite it producing a warning ? Maybe I am wrong . > > I have no idea what you are talking about, you are going to have to be a > lot more specific, or even better yet, post your patch. > > But remember, you can only do "one thing" per patch, so don't try to do > multiple things at the same time. Use a series of patches for that. > > good luck! > > greg k-h