From: jcfaracco@gmail.com (Julio Faracco)
To: kernelnewbies@lists.kernelnewbies.org
Subject: I have a large patch in the 2000 lines. What to do?
Date: Fri, 16 Oct 2015 18:14:01 -0300 [thread overview]
Message-ID: <CAENf94LAfnJaDDUv9k8By-yTC4kSyw-2iHb+QMDfkdGz3qwAWw@mail.gmail.com> (raw)
In-Reply-To: <20151010141446.GB6080@kroah.com>
I believe that it was answered.
What is the recommendation when I change a structure in a include file
and this change causes a lots of new changes, for example?
Julio Cesar Faracco
2015-10-10 11:14 GMT-03:00 Greg KH <greg@kroah.com>:
> On Sat, Oct 10, 2015 at 08:02:49AM +0700, Ivan Safonov wrote:
>> On 10/10/2015 02:20 AM, Greg KH wrote:
>> >On Fri, Oct 09, 2015 at 12:12:44PM -0700, Anish Kumar wrote:
>> >>
>> >>>On Oct 9, 2015, at 11:45 AM, Ivan Safonov <insafonov@gmail.com> wrote:
>> >>>
>> >>>Hi!
>> >>>
>> >>>I have a large patch in the 2000 lines, which replaces the macro BITn to
>> >>>BIT(n) in multiple files.
>> >>I will recommend sending RFC patch first and
>> >>Get the community comments.
>> >No, we just ignore RFC patches, we have too many "real" patches to deal
>> >with.
>> >
>> >>If they like your patch then divide the patch based on logic rather than lines of codes.
>> >>>Is it worth to split this patch into several parts?
>> >Yes.
>> >
>> >>>Is it sufficient to place the changes in each file in a separate part of
>> >>>patchset?
>> >Make it one-patch-per-driver.
>> >
>> >But note, cleanup patches like this are usually ignored by most
>> >subsystems, be aware that this type of thing is only usually accepted in
>> >the drivers/staging/ portion of the kernel.
>> >
>> >good luck!
>> >
>> >greg k-h
>>
>> The catch is that this patch is only to one driver.
>
> You know, providing specifics is always nice when asking questions...
>
> If it's just one driver, and you think the patch is correct, just send
> it in as normal, in one patch, as it should be "easy" to understand.
>
> But again, remember that these types of "cleanups" are not always
> appreciated for some portions of the kernel (again, you were not
> specific so I can't be specific back...)
>
> greg k-h
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2015-10-16 21:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 18:45 I have a large patch in the 2000 lines. What to do? Ivan Safonov
2015-10-09 19:12 ` Anish Kumar
2015-10-09 19:20 ` Greg KH
2015-10-10 1:02 ` Ivan Safonov
2015-10-10 14:14 ` Greg KH
2015-10-16 21:14 ` Julio Faracco [this message]
2015-10-16 21:31 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAENf94LAfnJaDDUv9k8By-yTC4kSyw-2iHb+QMDfkdGz3qwAWw@mail.gmail.com \
--to=jcfaracco@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).