* Continuous Interrupt Problem @ 2012-06-14 5:04 siddharth saxena 2012-06-14 5:13 ` anish singh 2012-06-14 6:31 ` Arun KS 0 siblings, 2 replies; 14+ messages in thread From: siddharth saxena @ 2012-06-14 5:04 UTC (permalink / raw) To: kernelnewbies Hi all I need help with an issue. I have written a touch driver for a device and used the flag IRQF_TRIGGER_LOW to request irq. Now, when I boot the device, the touch interrupts are coming already without touching the screen. Continuous interrupts are occurring without any touch. -- Regards Siddharth Saxena -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20120614/3b186a56/attachment.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Continuous Interrupt Problem 2012-06-14 5:04 Continuous Interrupt Problem siddharth saxena @ 2012-06-14 5:13 ` anish singh 2012-06-14 6:20 ` Sarbojit Ganguly 2012-06-14 6:31 ` Arun KS 1 sibling, 1 reply; 14+ messages in thread From: anish singh @ 2012-06-14 5:13 UTC (permalink / raw) To: kernelnewbies On Thu, Jun 14, 2012 at 10:34 AM, siddharth saxena <siddharthsaxena1989@gmail.com> wrote: > Hi all > > I need help with an issue. > I have written a touch driver for a device and used the flag > IRQF_TRIGGER_LOW to request irq. > Now, when I boot the device, the touch interrupts are coming already without > touching the screen. > Continuous interrupts are occurring without any touch. try disabling the interrupt after you do request_irq and once you are ready to handle interrupts you can enable it. > > > > -- > Regards > Siddharth Saxena > > > _______________________________________________ > Kernelnewbies mailing list > Kernelnewbies at kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Continuous Interrupt Problem 2012-06-14 5:13 ` anish singh @ 2012-06-14 6:20 ` Sarbojit Ganguly 0 siblings, 0 replies; 14+ messages in thread From: Sarbojit Ganguly @ 2012-06-14 6:20 UTC (permalink / raw) To: kernelnewbies To my understanding "IRQF_TRIGGER_LOW" is a flag which will trigger the interrupt when the line is _low_. Now, since you are not touching, the line remains low and satifies the condition. Hence the interrupt is triggered by the core. Can you change it to IRQF_TRIGGER_HIGH and recheck. Please consult the hardware documentation too. On 14 June 2012 10:43, anish singh <anish198519851985@gmail.com> wrote: > On Thu, Jun 14, 2012 at 10:34 AM, siddharth saxena > <siddharthsaxena1989@gmail.com> wrote: >> Hi all >> >> I need help with an issue. >> I have written a touch driver for a device and used the flag >> IRQF_TRIGGER_LOW to request irq. >> Now, when I boot the device, the touch interrupts are coming already without >> touching the screen. >> Continuous interrupts are occurring without any touch. > try disabling the interrupt after you do request_irq and once you are > ready to handle > interrupts you can enable it. >> >> >> >> -- >> Regards >> Siddharth Saxena >> >> >> _______________________________________________ >> Kernelnewbies mailing list >> Kernelnewbies at kernelnewbies.org >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> > > _______________________________________________ > Kernelnewbies mailing list > Kernelnewbies at kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies -- Regards, Sarbojit ^ permalink raw reply [flat|nested] 14+ messages in thread
* Continuous Interrupt Problem 2012-06-14 5:04 Continuous Interrupt Problem siddharth saxena 2012-06-14 5:13 ` anish singh @ 2012-06-14 6:31 ` Arun KS 2012-06-14 6:51 ` Sarbojit Ganguly 1 sibling, 1 reply; 14+ messages in thread From: Arun KS @ 2012-06-14 6:31 UTC (permalink / raw) To: kernelnewbies Hello Siddharth, On Thu, Jun 14, 2012 at 10:34 AM, siddharth saxena <siddharthsaxena1989@gmail.com> wrote: > Hi all > > I need help with an issue. > I have written a touch driver for a device and used the flag > IRQF_TRIGGER_LOW to request irq. > Now, when I boot the device, the touch interrupts are coming already without > touching the screen. > Continuous interrupts are occurring without any touch. Probably the default state of the gpio pin(which you configured as irq) is low. Check your HW schematic. TSC should have interrupt polarity(Active High/Low), which you have to choose depending on your schematic while initiallizing the TSC. Also different modes like assert interrupt when finger moving, when finger touch, or assert periodically. Hope these pointer will help you. Thanks, Arun > > > > -- > Regards > Siddharth Saxena > > > _______________________________________________ > Kernelnewbies mailing list > Kernelnewbies at kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Continuous Interrupt Problem 2012-06-14 6:31 ` Arun KS @ 2012-06-14 6:51 ` Sarbojit Ganguly 2012-06-14 8:41 ` siddharth saxena 0 siblings, 1 reply; 14+ messages in thread From: Sarbojit Ganguly @ 2012-06-14 6:51 UTC (permalink / raw) To: kernelnewbies Hi Arun, While I agree to your pointers but he is facing the problem of "interrupt floods" even before he touches. IMHO the culprit could be the flag. On 14 June 2012 12:01, Arun KS <getarunks@gmail.com> wrote: > Hello Siddharth, > > On Thu, Jun 14, 2012 at 10:34 AM, siddharth saxena > <siddharthsaxena1989@gmail.com> wrote: >> Hi all >> >> I need help with an issue. >> I have written a touch driver for a device and used the flag >> IRQF_TRIGGER_LOW to request irq. >> Now, when I boot the device, the touch interrupts are coming already without >> touching the screen. >> Continuous interrupts are occurring without any touch. > > Probably the default state of the gpio pin(which you configured as > irq) is low. Check your HW schematic. > > TSC should have interrupt polarity(Active High/Low), which you have to > choose depending on your schematic while initiallizing the TSC. > Also different modes like assert interrupt when finger moving, when > finger touch, or assert periodically. > > Hope these pointer will help you. > > Thanks, > Arun > >> >> >> >> -- >> Regards >> Siddharth Saxena >> >> >> _______________________________________________ >> Kernelnewbies mailing list >> Kernelnewbies at kernelnewbies.org >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> > > _______________________________________________ > Kernelnewbies mailing list > Kernelnewbies at kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies -- Regards, Sarbojit ^ permalink raw reply [flat|nested] 14+ messages in thread
* Continuous Interrupt Problem 2012-06-14 6:51 ` Sarbojit Ganguly @ 2012-06-14 8:41 ` siddharth saxena 2012-06-14 8:54 ` anish singh 2012-06-14 9:02 ` Arun KS 0 siblings, 2 replies; 14+ messages in thread From: siddharth saxena @ 2012-06-14 8:41 UTC (permalink / raw) To: kernelnewbies Hi Arun I tried changing the flag to IRQF_TRIGGER_HIGH but then device is behaving abnormally(Hangs and is dead after some time). Flooding interrupts still observed. Problem not solved. I want to know, are we supposed to change interrupt pin status or it is done automatically when we return IRQ_HANDLED. On Thu, Jun 14, 2012 at 12:21 PM, Sarbojit Ganguly < unixman.linuxboy@gmail.com> wrote: > Hi Arun, > > While I agree to your pointers but he is facing the problem of > "interrupt floods" even before he touches. > IMHO the culprit could be the flag. > > On 14 June 2012 12:01, Arun KS <getarunks@gmail.com> wrote: > > Hello Siddharth, > > > > On Thu, Jun 14, 2012 at 10:34 AM, siddharth saxena > > <siddharthsaxena1989@gmail.com> wrote: > >> Hi all > >> > >> I need help with an issue. > >> I have written a touch driver for a device and used the flag > >> IRQF_TRIGGER_LOW to request irq. > >> Now, when I boot the device, the touch interrupts are coming already > without > >> touching the screen. > >> Continuous interrupts are occurring without any touch. > > > > Probably the default state of the gpio pin(which you configured as > > irq) is low. Check your HW schematic. > > > > TSC should have interrupt polarity(Active High/Low), which you have to > > choose depending on your schematic while initiallizing the TSC. > > Also different modes like assert interrupt when finger moving, when > > finger touch, or assert periodically. > > > > Hope these pointer will help you. > > > > Thanks, > > Arun > > > >> > >> > >> > >> -- > >> Regards > >> Siddharth Saxena > >> > >> > >> _______________________________________________ > >> Kernelnewbies mailing list > >> Kernelnewbies at kernelnewbies.org > >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > >> > > > > _______________________________________________ > > Kernelnewbies mailing list > > Kernelnewbies at kernelnewbies.org > > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > > > -- > Regards, > Sarbojit > -- Regards Siddharth Saxena -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20120614/9153cb64/attachment.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Continuous Interrupt Problem 2012-06-14 8:41 ` siddharth saxena @ 2012-06-14 8:54 ` anish singh 2012-06-14 9:05 ` siddharth saxena 2012-06-14 9:02 ` Arun KS 1 sibling, 1 reply; 14+ messages in thread From: anish singh @ 2012-06-14 8:54 UTC (permalink / raw) To: kernelnewbies On Thu, Jun 14, 2012 at 2:11 PM, siddharth saxena <siddharthsaxena1989@gmail.com> wrote: > Hi Arun > > I tried changing the flag to IRQF_TRIGGER_HIGH but then device is behaving > abnormally(Hangs and is dead after some time). > Flooding interrupts still observed. Problem not solved. > > I want to know, are we supposed to change interrupt pin status or it is done > automatically when we return IRQ_HANDLED. why don't you paste the code for your probe routine where you are calling request_irq. Are you using threaded irq?It would be difficult to diagnose the problem without looking at your TSP manual and your code to find out the problem. > > > > > On Thu, Jun 14, 2012 at 12:21 PM, Sarbojit Ganguly > <unixman.linuxboy@gmail.com> wrote: >> >> Hi Arun, >> >> While I agree to your pointers but he is facing the problem of >> "interrupt floods" even before he touches. >> IMHO the culprit could be the flag. >> >> On 14 June 2012 12:01, Arun KS <getarunks@gmail.com> wrote: >> > Hello Siddharth, >> > >> > On Thu, Jun 14, 2012 at 10:34 AM, siddharth saxena >> > <siddharthsaxena1989@gmail.com> wrote: >> >> Hi all >> >> >> >> I need help with an issue. >> >> I have written a touch driver for a device and used the flag >> >> IRQF_TRIGGER_LOW to request irq. >> >> Now, when I boot the device, the touch interrupts are coming already >> >> without >> >> touching the screen. >> >> Continuous interrupts are occurring without any touch. >> > >> > Probably the default state of the gpio pin(which you configured as >> > irq) is low. Check your HW schematic. >> > >> > TSC should have interrupt polarity(Active High/Low), which you have to >> > choose depending on your schematic while initiallizing the TSC. >> > Also different modes like assert interrupt when finger moving, when >> > finger touch, or assert periodically. >> > >> > Hope these pointer will help you. >> > >> > Thanks, >> > Arun >> > >> >> >> >> >> >> >> >> -- >> >> Regards >> >> Siddharth Saxena >> >> >> >> >> >> _______________________________________________ >> >> Kernelnewbies mailing list >> >> Kernelnewbies at kernelnewbies.org >> >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> >> >> > >> > _______________________________________________ >> > Kernelnewbies mailing list >> > Kernelnewbies at kernelnewbies.org >> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> >> >> >> -- >> Regards, >> Sarbojit > > > > > -- > Regards > Siddharth Saxena > > > _______________________________________________ > Kernelnewbies mailing list > Kernelnewbies at kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Continuous Interrupt Problem 2012-06-14 8:54 ` anish singh @ 2012-06-14 9:05 ` siddharth saxena 2012-06-14 9:29 ` Sarbojit Ganguly 2012-06-15 10:22 ` Shaji Yusuf 0 siblings, 2 replies; 14+ messages in thread From: siddharth saxena @ 2012-06-14 9:05 UTC (permalink / raw) To: kernelnewbies Initialized in Probe : if (device->irq) { ret = request_irq(device->irq, ts_int_handler, IRQF_TRIGGER_LOW, DRIVER_NAME, device); if (ret) { pr_err("unable to register touch irq.(%s)\r\n", device->input_dev->name); goto err_request_irq; } } The pin by default has to be initialized to Active Low. On Thu, Jun 14, 2012 at 2:24 PM, anish singh <anish198519851985@gmail.com>wrote: > On Thu, Jun 14, 2012 at 2:11 PM, siddharth saxena > <siddharthsaxena1989@gmail.com> wrote: > > Hi Arun > > > > I tried changing the flag to IRQF_TRIGGER_HIGH but then device is > behaving > > abnormally(Hangs and is dead after some time). > > Flooding interrupts still observed. Problem not solved. > > > > I want to know, are we supposed to change interrupt pin status or it is > done > > automatically when we return IRQ_HANDLED. > why don't you paste the code for your probe routine where you are > calling request_irq. > Are you using threaded irq?It would be difficult to diagnose the > problem without looking > at your TSP manual and your code to find out the problem. > > > > > > > > > > On Thu, Jun 14, 2012 at 12:21 PM, Sarbojit Ganguly > > <unixman.linuxboy@gmail.com> wrote: > >> > >> Hi Arun, > >> > >> While I agree to your pointers but he is facing the problem of > >> "interrupt floods" even before he touches. > >> IMHO the culprit could be the flag. > >> > >> On 14 June 2012 12:01, Arun KS <getarunks@gmail.com> wrote: > >> > Hello Siddharth, > >> > > >> > On Thu, Jun 14, 2012 at 10:34 AM, siddharth saxena > >> > <siddharthsaxena1989@gmail.com> wrote: > >> >> Hi all > >> >> > >> >> I need help with an issue. > >> >> I have written a touch driver for a device and used the flag > >> >> IRQF_TRIGGER_LOW to request irq. > >> >> Now, when I boot the device, the touch interrupts are coming already > >> >> without > >> >> touching the screen. > >> >> Continuous interrupts are occurring without any touch. > >> > > >> > Probably the default state of the gpio pin(which you configured as > >> > irq) is low. Check your HW schematic. > >> > > >> > TSC should have interrupt polarity(Active High/Low), which you have to > >> > choose depending on your schematic while initiallizing the TSC. > >> > Also different modes like assert interrupt when finger moving, when > >> > finger touch, or assert periodically. > >> > > >> > Hope these pointer will help you. > >> > > >> > Thanks, > >> > Arun > >> > > >> >> > >> >> > >> >> > >> >> -- > >> >> Regards > >> >> Siddharth Saxena > >> >> > >> >> > >> >> _______________________________________________ > >> >> Kernelnewbies mailing list > >> >> Kernelnewbies at kernelnewbies.org > >> >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > >> >> > >> > > >> > _______________________________________________ > >> > Kernelnewbies mailing list > >> > Kernelnewbies at kernelnewbies.org > >> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > >> > >> > >> > >> -- > >> Regards, > >> Sarbojit > > > > > > > > > > -- > > Regards > > Siddharth Saxena > > > > > > _______________________________________________ > > Kernelnewbies mailing list > > Kernelnewbies at kernelnewbies.org > > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > > -- Regards Siddharth Saxena -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20120614/7df1fb8a/attachment.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Continuous Interrupt Problem 2012-06-14 9:05 ` siddharth saxena @ 2012-06-14 9:29 ` Sarbojit Ganguly 2012-06-14 9:39 ` anish singh 2012-06-15 10:22 ` Shaji Yusuf 1 sibling, 1 reply; 14+ messages in thread From: Sarbojit Ganguly @ 2012-06-14 9:29 UTC (permalink / raw) To: kernelnewbies Can you give the hardware details please? On 14 June 2012 14:35, siddharth saxena <siddharthsaxena1989@gmail.com> wrote: > Initialized in Probe : > > if (device->irq) { > ??? ??? ret = request_irq(device->irq, ts_int_handler, > ??? ??? IRQF_TRIGGER_LOW, DRIVER_NAME, device); > ??? ??? if (ret) { > ??? ??? ??? pr_err("unable to register touch irq.(%s)\r\n", > ??? ??? ??? device->input_dev->name); > ??? ??? ??? goto err_request_irq; > ??? ??? } > ??? } > > > > The pin by default has to be initialized to Active Low. > > > > > > On Thu, Jun 14, 2012 at 2:24 PM, anish singh <anish198519851985@gmail.com> > wrote: >> >> On Thu, Jun 14, 2012 at 2:11 PM, siddharth saxena >> <siddharthsaxena1989@gmail.com> wrote: >> > Hi Arun >> > >> > I tried changing the flag to IRQF_TRIGGER_HIGH but then device is >> > behaving >> > abnormally(Hangs and is dead after some time). >> > Flooding interrupts still observed. Problem not solved. >> > >> > I want to know, are we supposed to change interrupt pin status or it is >> > done >> > automatically when we return IRQ_HANDLED. >> why don't you paste the code for your probe routine where you are >> calling request_irq. >> Are you using threaded irq?It would be difficult to diagnose the >> problem without looking >> at your TSP manual and your code to find out the problem. >> > >> > >> > >> > >> > On Thu, Jun 14, 2012 at 12:21 PM, Sarbojit Ganguly >> > <unixman.linuxboy@gmail.com> wrote: >> >> >> >> Hi Arun, >> >> >> >> While I agree to your pointers but he is facing the problem of >> >> "interrupt floods" even before he touches. >> >> IMHO the culprit could be the flag. >> >> >> >> On 14 June 2012 12:01, Arun KS <getarunks@gmail.com> wrote: >> >> > Hello Siddharth, >> >> > >> >> > On Thu, Jun 14, 2012 at 10:34 AM, siddharth saxena >> >> > <siddharthsaxena1989@gmail.com> wrote: >> >> >> Hi all >> >> >> >> >> >> I need help with an issue. >> >> >> I have written a touch driver for a device and used the flag >> >> >> IRQF_TRIGGER_LOW to request irq. >> >> >> Now, when I boot the device, the touch interrupts are coming already >> >> >> without >> >> >> touching the screen. >> >> >> Continuous interrupts are occurring without any touch. >> >> > >> >> > Probably the default state of the gpio pin(which you configured as >> >> > irq) is low. Check your HW schematic. >> >> > >> >> > TSC should have interrupt polarity(Active High/Low), which you have >> >> > to >> >> > choose depending on your schematic while initiallizing the TSC. >> >> > Also different modes like assert interrupt when finger moving, when >> >> > finger touch, or assert periodically. >> >> > >> >> > Hope these pointer will help you. >> >> > >> >> > Thanks, >> >> > Arun >> >> > >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> >> Regards >> >> >> Siddharth Saxena >> >> >> >> >> >> >> >> >> _______________________________________________ >> >> >> Kernelnewbies mailing list >> >> >> Kernelnewbies at kernelnewbies.org >> >> >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> >> >> >> >> > >> >> > _______________________________________________ >> >> > Kernelnewbies mailing list >> >> > Kernelnewbies at kernelnewbies.org >> >> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> >> >> >> >> >> >> >> -- >> >> Regards, >> >> Sarbojit >> > >> > >> > >> > >> > -- >> > Regards >> > Siddharth Saxena >> > >> > >> > _______________________________________________ >> > Kernelnewbies mailing list >> > Kernelnewbies at kernelnewbies.org >> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> > > > > > > -- > Regards > Siddharth Saxena > -- Regards, Sarbojit ^ permalink raw reply [flat|nested] 14+ messages in thread
* Continuous Interrupt Problem 2012-06-14 9:29 ` Sarbojit Ganguly @ 2012-06-14 9:39 ` anish singh 2012-06-14 11:38 ` Sarbojit Ganguly 0 siblings, 1 reply; 14+ messages in thread From: anish singh @ 2012-06-14 9:39 UTC (permalink / raw) To: kernelnewbies On Thu, Jun 14, 2012 at 2:59 PM, Sarbojit Ganguly <unixman.linuxboy@gmail.com> wrote: > Can you give the hardware details please? Sarbojit please don't top post. Anyway the problem is resolved as there was no problem in the first place. TSP driver is doing i2c-read/write at regular intervals of time in his driver and he assumed that it should not happen as that would consume power but it is by design. Time fires ->workqueue schedule->read i2c/write i2c and report to input subsystem. He is not having access to the tsp manaul so we don't know why this is designed this way. > > On 14 June 2012 14:35, siddharth saxena <siddharthsaxena1989@gmail.com> wrote: >> Initialized in Probe : >> >> if (device->irq) { >> ??? ??? ret = request_irq(device->irq, ts_int_handler, >> ??? ??? IRQF_TRIGGER_LOW, DRIVER_NAME, device); >> ??? ??? if (ret) { >> ??? ??? ??? pr_err("unable to register touch irq.(%s)\r\n", >> ??? ??? ??? device->input_dev->name); >> ??? ??? ??? goto err_request_irq; >> ??? ??? } >> ??? } >> >> >> >> The pin by default has to be initialized to Active Low. >> >> >> >> >> >> On Thu, Jun 14, 2012 at 2:24 PM, anish singh <anish198519851985@gmail.com> >> wrote: >>> >>> On Thu, Jun 14, 2012 at 2:11 PM, siddharth saxena >>> <siddharthsaxena1989@gmail.com> wrote: >>> > Hi Arun >>> > >>> > I tried changing the flag to IRQF_TRIGGER_HIGH but then device is >>> > behaving >>> > abnormally(Hangs and is dead after some time). >>> > Flooding interrupts still observed. Problem not solved. >>> > >>> > I want to know, are we supposed to change interrupt pin status or it is >>> > done >>> > automatically when we return IRQ_HANDLED. >>> why don't you paste the code for your probe routine where you are >>> calling request_irq. >>> Are you using threaded irq?It would be difficult to diagnose the >>> problem without looking >>> at your TSP manual and your code to find out the problem. >>> > >>> > >>> > >>> > >>> > On Thu, Jun 14, 2012 at 12:21 PM, Sarbojit Ganguly >>> > <unixman.linuxboy@gmail.com> wrote: >>> >> >>> >> Hi Arun, >>> >> >>> >> While I agree to your pointers but he is facing the problem of >>> >> "interrupt floods" even before he touches. >>> >> IMHO the culprit could be the flag. >>> >> >>> >> On 14 June 2012 12:01, Arun KS <getarunks@gmail.com> wrote: >>> >> > Hello Siddharth, >>> >> > >>> >> > On Thu, Jun 14, 2012 at 10:34 AM, siddharth saxena >>> >> > <siddharthsaxena1989@gmail.com> wrote: >>> >> >> Hi all >>> >> >> >>> >> >> I need help with an issue. >>> >> >> I have written a touch driver for a device and used the flag >>> >> >> IRQF_TRIGGER_LOW to request irq. >>> >> >> Now, when I boot the device, the touch interrupts are coming already >>> >> >> without >>> >> >> touching the screen. >>> >> >> Continuous interrupts are occurring without any touch. >>> >> > >>> >> > Probably the default state of the gpio pin(which you configured as >>> >> > irq) is low. Check your HW schematic. >>> >> > >>> >> > TSC should have interrupt polarity(Active High/Low), which you have >>> >> > to >>> >> > choose depending on your schematic while initiallizing the TSC. >>> >> > Also different modes like assert interrupt when finger moving, when >>> >> > finger touch, or assert periodically. >>> >> > >>> >> > Hope these pointer will help you. >>> >> > >>> >> > Thanks, >>> >> > Arun >>> >> > >>> >> >> >>> >> >> >>> >> >> >>> >> >> -- >>> >> >> Regards >>> >> >> Siddharth Saxena >>> >> >> >>> >> >> >>> >> >> _______________________________________________ >>> >> >> Kernelnewbies mailing list >>> >> >> Kernelnewbies at kernelnewbies.org >>> >> >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >>> >> >> >>> >> > >>> >> > _______________________________________________ >>> >> > Kernelnewbies mailing list >>> >> > Kernelnewbies at kernelnewbies.org >>> >> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >>> >> >>> >> >>> >> >>> >> -- >>> >> Regards, >>> >> Sarbojit >>> > >>> > >>> > >>> > >>> > -- >>> > Regards >>> > Siddharth Saxena >>> > >>> > >>> > _______________________________________________ >>> > Kernelnewbies mailing list >>> > Kernelnewbies at kernelnewbies.org >>> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >>> > >> >> >> >> >> -- >> Regards >> Siddharth Saxena >> > > > > -- > Regards, > Sarbojit ^ permalink raw reply [flat|nested] 14+ messages in thread
* Continuous Interrupt Problem 2012-06-14 9:39 ` anish singh @ 2012-06-14 11:38 ` Sarbojit Ganguly 0 siblings, 0 replies; 14+ messages in thread From: Sarbojit Ganguly @ 2012-06-14 11:38 UTC (permalink / raw) To: kernelnewbies My apologies as I did not get mail where the problem he faced was resolved. Anyway, I faced almost similar issue where the problem boiled down to the flag. So I was kind of interested. On 14 June 2012 15:09, anish singh <anish198519851985@gmail.com> wrote: > On Thu, Jun 14, 2012 at 2:59 PM, Sarbojit Ganguly > <unixman.linuxboy@gmail.com> wrote: >> Can you give the hardware details please? > Sarbojit please don't top post. > Anyway the problem is resolved as there was no problem in the first place. > TSP driver is doing i2c-read/write at regular intervals of time in his > driver and he assumed > that it should not happen as that would consume power but it is by design. > Time fires ->workqueue schedule->read i2c/write i2c and report to > input subsystem. > He is not having access to the tsp manaul so we don't know why this is > designed this way. >> >> On 14 June 2012 14:35, siddharth saxena <siddharthsaxena1989@gmail.com> wrote: >>> Initialized in Probe : >>> >>> if (device->irq) { >>> ??? ??? ret = request_irq(device->irq, ts_int_handler, >>> ??? ??? IRQF_TRIGGER_LOW, DRIVER_NAME, device); >>> ??? ??? if (ret) { >>> ??? ??? ??? pr_err("unable to register touch irq.(%s)\r\n", >>> ??? ??? ??? device->input_dev->name); >>> ??? ??? ??? goto err_request_irq; >>> ??? ??? } >>> ??? } >>> >>> >>> >>> The pin by default has to be initialized to Active Low. >>> >>> >>> >>> >>> >>> On Thu, Jun 14, 2012 at 2:24 PM, anish singh <anish198519851985@gmail.com> >>> wrote: >>>> >>>> On Thu, Jun 14, 2012 at 2:11 PM, siddharth saxena >>>> <siddharthsaxena1989@gmail.com> wrote: >>>> > Hi Arun >>>> > >>>> > I tried changing the flag to IRQF_TRIGGER_HIGH but then device is >>>> > behaving >>>> > abnormally(Hangs and is dead after some time). >>>> > Flooding interrupts still observed. Problem not solved. >>>> > >>>> > I want to know, are we supposed to change interrupt pin status or it is >>>> > done >>>> > automatically when we return IRQ_HANDLED. >>>> why don't you paste the code for your probe routine where you are >>>> calling request_irq. >>>> Are you using threaded irq?It would be difficult to diagnose the >>>> problem without looking >>>> at your TSP manual and your code to find out the problem. >>>> > >>>> > >>>> > >>>> > >>>> > On Thu, Jun 14, 2012 at 12:21 PM, Sarbojit Ganguly >>>> > <unixman.linuxboy@gmail.com> wrote: >>>> >> >>>> >> Hi Arun, >>>> >> >>>> >> While I agree to your pointers but he is facing the problem of >>>> >> "interrupt floods" even before he touches. >>>> >> IMHO the culprit could be the flag. >>>> >> >>>> >> On 14 June 2012 12:01, Arun KS <getarunks@gmail.com> wrote: >>>> >> > Hello Siddharth, >>>> >> > >>>> >> > On Thu, Jun 14, 2012 at 10:34 AM, siddharth saxena >>>> >> > <siddharthsaxena1989@gmail.com> wrote: >>>> >> >> Hi all >>>> >> >> >>>> >> >> I need help with an issue. >>>> >> >> I have written a touch driver for a device and used the flag >>>> >> >> IRQF_TRIGGER_LOW to request irq. >>>> >> >> Now, when I boot the device, the touch interrupts are coming already >>>> >> >> without >>>> >> >> touching the screen. >>>> >> >> Continuous interrupts are occurring without any touch. >>>> >> > >>>> >> > Probably the default state of the gpio pin(which you configured as >>>> >> > irq) is low. Check your HW schematic. >>>> >> > >>>> >> > TSC should have interrupt polarity(Active High/Low), which you have >>>> >> > to >>>> >> > choose depending on your schematic while initiallizing the TSC. >>>> >> > Also different modes like assert interrupt when finger moving, when >>>> >> > finger touch, or assert periodically. >>>> >> > >>>> >> > Hope these pointer will help you. >>>> >> > >>>> >> > Thanks, >>>> >> > Arun >>>> >> > >>>> >> >> >>>> >> >> >>>> >> >> >>>> >> >> -- >>>> >> >> Regards >>>> >> >> Siddharth Saxena >>>> >> >> >>>> >> >> >>>> >> >> _______________________________________________ >>>> >> >> Kernelnewbies mailing list >>>> >> >> Kernelnewbies at kernelnewbies.org >>>> >> >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >>>> >> >> >>>> >> > >>>> >> > _______________________________________________ >>>> >> > Kernelnewbies mailing list >>>> >> > Kernelnewbies at kernelnewbies.org >>>> >> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >>>> >> >>>> >> >>>> >> >>>> >> -- >>>> >> Regards, >>>> >> Sarbojit >>>> > >>>> > >>>> > >>>> > >>>> > -- >>>> > Regards >>>> > Siddharth Saxena >>>> > >>>> > >>>> > _______________________________________________ >>>> > Kernelnewbies mailing list >>>> > Kernelnewbies at kernelnewbies.org >>>> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >>>> > >>> >>> >>> >>> >>> -- >>> Regards >>> Siddharth Saxena >>> >> >> >> >> -- >> Regards, >> Sarbojit -- Regards, Sarbojit ^ permalink raw reply [flat|nested] 14+ messages in thread
* Continuous Interrupt Problem 2012-06-14 9:05 ` siddharth saxena 2012-06-14 9:29 ` Sarbojit Ganguly @ 2012-06-15 10:22 ` Shaji Yusuf 2012-06-16 16:25 ` anish kumar 1 sibling, 1 reply; 14+ messages in thread From: Shaji Yusuf @ 2012-06-15 10:22 UTC (permalink / raw) To: kernelnewbies Is the issue resolved? This seems to be more of either a device that's buggy or some misunderstanding in understanding the device specs. I had a similar issue with one of our devices. When I get an interrupt I would do some thing in the device (reading buffers writing some registers and stuff) that should reset the Interrupt pin to high state again. But the hardware had a bug that would not let the Interrupt pin reset, and once I return from the Interrupt it would strike again causing the system to freeze.? Thanks Shaji Yusuf ________________________________ From: siddharth saxena <siddharthsaxena1989@gmail.com> To: anish singh <anish198519851985@gmail.com> Cc: Arun KS <getarunks@gmail.com>; Sarbojit Ganguly <unixman.linuxboy@gmail.com>; kernelnewbies at kernelnewbies.org Sent: Thursday, June 14, 2012 2:35 PM Subject: Re: Continuous Interrupt Problem Initialized in Probe : if (device->irq) { ??? ??? ret = request_irq(device->irq, ts_int_handler, ??? ??? IRQF_TRIGGER_LOW, DRIVER_NAME, device); ??? ??? if (ret) { ??? ??? ??? pr_err("unable to register touch irq.(%s)\r\n", ??? ??? ??? device->input_dev->name); ??? ??? ??? goto err_request_irq; ??? ??? } ??? } The pin by default has to be initialized to Active Low. On Thu, Jun 14, 2012 at 2:24 PM, anish singh <anish198519851985@gmail.com> wrote: On Thu, Jun 14, 2012 at 2:11 PM, siddharth saxena ><siddharthsaxena1989@gmail.com> wrote: >> Hi Arun >> >> I tried changing the flag to IRQF_TRIGGER_HIGH but then device is behaving >> abnormally(Hangs and is dead after some time). >> Flooding interrupts still observed. Problem not solved. >> >> I want to know, are we supposed to change interrupt pin status or it is done >> automatically when we return IRQ_HANDLED. >why don't you paste the code for your probe routine where you are >calling request_irq. >Are you using threaded irq?It would be difficult to diagnose the >problem without looking >at your TSP manual and your code to find out the problem. > >> >> >> >> >> On Thu, Jun 14, 2012 at 12:21 PM, Sarbojit Ganguly >> <unixman.linuxboy@gmail.com> wrote: >>> >>> Hi Arun, >>> >>> While I agree to your pointers but he is facing the problem of >>> "interrupt floods" even before he touches. >>> IMHO the culprit could be the flag. >>> >>> On 14 June 2012 12:01, Arun KS <getarunks@gmail.com> wrote: >>> > Hello Siddharth, >>> > >>> > On Thu, Jun 14, 2012 at 10:34 AM, siddharth saxena >>> > <siddharthsaxena1989@gmail.com> wrote: >>> >> Hi all >>> >> >>> >> I need help with an issue. >>> >> I have written a touch driver for a device and used the flag >>> >> IRQF_TRIGGER_LOW to request irq. >>> >> Now, when I boot the device, the touch interrupts are coming already >>> >> without >>> >> touching the screen. >>> >> Continuous interrupts are occurring without any touch. >>> > >>> > Probably the default state of the gpio pin(which you configured as >>> > irq) is low. Check your HW schematic. >>> > >>> > TSC should have interrupt polarity(Active High/Low), which you have to >>> > choose depending on your schematic while initiallizing the TSC. >>> > Also different modes like assert interrupt when finger moving, when >>> > finger touch, or assert periodically. >>> > >>> > Hope these pointer will help you. >>> > >>> > Thanks, >>> > Arun >>> > >>> >> >>> >> >>> >> >>> >> -- >>> >> Regards >>> >> Siddharth Saxena >>> >> >>> >> >>> >> _______________________________________________ >>> >> Kernelnewbies mailing list >>> >> Kernelnewbies at kernelnewbies.org >>> >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >>> >> >>> > >>> > _______________________________________________ >>> > Kernelnewbies mailing list >>> > Kernelnewbies at kernelnewbies.org >>> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >>> >>> >>> >>> -- >>> Regards, >>> Sarbojit >> >> >> >> >> -- >> Regards >> Siddharth Saxena >> >> >> _______________________________________________ >> Kernelnewbies mailing list >> Kernelnewbies at kernelnewbies.org >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> > -- Regards Siddharth Saxena _______________________________________________ Kernelnewbies mailing list Kernelnewbies at kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20120615/b463dbf6/attachment.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Continuous Interrupt Problem 2012-06-15 10:22 ` Shaji Yusuf @ 2012-06-16 16:25 ` anish kumar 0 siblings, 0 replies; 14+ messages in thread From: anish kumar @ 2012-06-16 16:25 UTC (permalink / raw) To: kernelnewbies On Fri, 2012-06-15 at 03:22 -0700, Shaji Yusuf wrote: > Is the issue resolved? > > > This seems to be more of either a device that's buggy or some > misunderstanding in understanding the device specs. I checked with siddharth and understanding in device specs was the problem. > > > I had a similar issue with one of our devices. When I get an interrupt > I would do some thing in the device (reading buffers writing some > registers and stuff) that should reset the Interrupt pin to high state > again. But the hardware had a bug that would not let the Interrupt pin > reset, and once I return from the Interrupt it would strike again > causing the system to freeze. > > > Thanks > > Shaji Yusuf > > > > > > ______________________________________________________________________ > From: siddharth saxena <siddharthsaxena1989@gmail.com> > To: anish singh <anish198519851985@gmail.com> > Cc: Arun KS <getarunks@gmail.com>; Sarbojit Ganguly > <unixman.linuxboy@gmail.com>; kernelnewbies at kernelnewbies.org > Sent: Thursday, June 14, 2012 2:35 PM > Subject: Re: Continuous Interrupt Problem > > > Initialized in Probe : > > if (device->irq) { > ret = request_irq(device->irq, ts_int_handler, > IRQF_TRIGGER_LOW, DRIVER_NAME, device); > if (ret) { > pr_err("unable to register touch irq.(%s)\r\n", > device->input_dev->name); > goto err_request_irq; > } > } > > > > The pin by default has to be initialized to Active Low. > > > > > On Thu, Jun 14, 2012 at 2:24 PM, anish singh > <anish198519851985@gmail.com> wrote: > On Thu, Jun 14, 2012 at 2:11 PM, siddharth saxena > <siddharthsaxena1989@gmail.com> wrote: > > Hi Arun > > > > I tried changing the flag to IRQF_TRIGGER_HIGH but then > device is behaving > > abnormally(Hangs and is dead after some time). > > Flooding interrupts still observed. Problem not solved. > > > > I want to know, are we supposed to change interrupt pin > status or it is done > > automatically when we return IRQ_HANDLED. > > why don't you paste the code for your probe routine where you > are > calling request_irq. > Are you using threaded irq?It would be difficult to diagnose > the > problem without looking > at your TSP manual and your code to find out the problem. > > > > > > > > > > On Thu, Jun 14, 2012 at 12:21 PM, Sarbojit Ganguly > > <unixman.linuxboy@gmail.com> wrote: > >> > >> Hi Arun, > >> > >> While I agree to your pointers but he is facing the problem > of > >> "interrupt floods" even before he touches. > >> IMHO the culprit could be the flag. > >> > >> On 14 June 2012 12:01, Arun KS <getarunks@gmail.com> wrote: > >> > Hello Siddharth, > >> > > >> > On Thu, Jun 14, 2012 at 10:34 AM, siddharth saxena > >> > <siddharthsaxena1989@gmail.com> wrote: > >> >> Hi all > >> >> > >> >> I need help with an issue. > >> >> I have written a touch driver for a device and used the > flag > >> >> IRQF_TRIGGER_LOW to request irq. > >> >> Now, when I boot the device, the touch interrupts are > coming already > >> >> without > >> >> touching the screen. > >> >> Continuous interrupts are occurring without any touch. > >> > > >> > Probably the default state of the gpio pin(which you > configured as > >> > irq) is low. Check your HW schematic. > >> > > >> > TSC should have interrupt polarity(Active High/Low), > which you have to > >> > choose depending on your schematic while initiallizing > the TSC. > >> > Also different modes like assert interrupt when finger > moving, when > >> > finger touch, or assert periodically. > >> > > >> > Hope these pointer will help you. > >> > > >> > Thanks, > >> > Arun > >> > > >> >> > >> >> > >> >> > >> >> -- > >> >> Regards > >> >> Siddharth Saxena > >> >> > >> >> > >> >> _______________________________________________ > >> >> Kernelnewbies mailing list > >> >> Kernelnewbies at kernelnewbies.org > >> >> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > >> >> > >> > > >> > _______________________________________________ > >> > Kernelnewbies mailing list > >> > Kernelnewbies at kernelnewbies.org > >> > > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > >> > >> > >> > >> -- > >> Regards, > >> Sarbojit > > > > > > > > > > -- > > Regards > > Siddharth Saxena > > > > > > _______________________________________________ > > Kernelnewbies mailing list > > Kernelnewbies at kernelnewbies.org > > > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > > > > > > -- > Regards > Siddharth Saxena > > > > _______________________________________________ > Kernelnewbies mailing list > Kernelnewbies at kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Continuous Interrupt Problem 2012-06-14 8:41 ` siddharth saxena 2012-06-14 8:54 ` anish singh @ 2012-06-14 9:02 ` Arun KS 1 sibling, 0 replies; 14+ messages in thread From: Arun KS @ 2012-06-14 9:02 UTC (permalink / raw) To: kernelnewbies Hello Siddharth, On Thu, Jun 14, 2012 at 2:11 PM, siddharth saxena <siddharthsaxena1989@gmail.com> wrote: > Hi Arun > > I tried changing the flag to IRQF_TRIGGER_HIGH but then device is behaving > abnormally(Hangs and is dead after some time). > Flooding interrupts still observed. Problem not solved. > > I want to know, are we supposed to change interrupt pin status or it is done > automatically when we return IRQ_HANDLED. What is the default state of your irq gpio pin? Is it pulled high or low? What is the interrupt asset conditon from your TSC(Active high/low or Edge triggered)? Thanks, Arun > > > > > On Thu, Jun 14, 2012 at 12:21 PM, Sarbojit Ganguly > <unixman.linuxboy@gmail.com> wrote: >> >> Hi Arun, >> >> While I agree to your pointers but he is facing the problem of >> "interrupt floods" even before he touches. >> IMHO the culprit could be the flag. >> >> On 14 June 2012 12:01, Arun KS <getarunks@gmail.com> wrote: >> > Hello Siddharth, >> > >> > On Thu, Jun 14, 2012 at 10:34 AM, siddharth saxena >> > <siddharthsaxena1989@gmail.com> wrote: >> >> Hi all >> >> >> >> I need help with an issue. >> >> I have written a touch driver for a device and used the flag >> >> IRQF_TRIGGER_LOW to request irq. >> >> Now, when I boot the device, the touch interrupts are coming already >> >> without >> >> touching the screen. >> >> Continuous interrupts are occurring without any touch. >> > >> > Probably the default state of the gpio pin(which you configured as >> > irq) is low. Check your HW schematic. >> > >> > TSC should have interrupt polarity(Active High/Low), which you have to >> > choose depending on your schematic while initiallizing the TSC. >> > Also different modes like assert interrupt when finger moving, when >> > finger touch, or assert periodically. >> > >> > Hope these pointer will help you. >> > >> > Thanks, >> > Arun >> > >> >> >> >> >> >> >> >> -- >> >> Regards >> >> Siddharth Saxena >> >> >> >> >> >> _______________________________________________ >> >> Kernelnewbies mailing list >> >> Kernelnewbies at kernelnewbies.org >> >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> >> >> > >> > _______________________________________________ >> > Kernelnewbies mailing list >> > Kernelnewbies at kernelnewbies.org >> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> >> >> >> -- >> Regards, >> Sarbojit > > > > > -- > Regards > Siddharth Saxena > ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2012-06-16 16:25 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-06-14 5:04 Continuous Interrupt Problem siddharth saxena 2012-06-14 5:13 ` anish singh 2012-06-14 6:20 ` Sarbojit Ganguly 2012-06-14 6:31 ` Arun KS 2012-06-14 6:51 ` Sarbojit Ganguly 2012-06-14 8:41 ` siddharth saxena 2012-06-14 8:54 ` anish singh 2012-06-14 9:05 ` siddharth saxena 2012-06-14 9:29 ` Sarbojit Ganguly 2012-06-14 9:39 ` anish singh 2012-06-14 11:38 ` Sarbojit Ganguly 2012-06-15 10:22 ` Shaji Yusuf 2012-06-16 16:25 ` anish kumar 2012-06-14 9:02 ` Arun KS
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).