kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: elezegarcia@gmail.com (Ezequiel García)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH 1/2] staging: easycap: Clean comment style in easycap_usb_probe()
Date: Sun, 19 Feb 2012 16:53:59 -0300	[thread overview]
Message-ID: <CALF0-+VCb6S=kokeimO-+ophX+5tyvbv9Q6uSDxtsjXHLdKY8w@mail.gmail.com> (raw)
In-Reply-To: <20120218205121.GD2855@mwanda>

Hi,

2012/2/18 Dan Carpenter <dan.carpenter@oracle.com>:
> The first line of the comment here should be a blank line.

Ok.

>
> ? ? ? ?/*
> ? ? ? ? * blah blah blah
> ? ? ? ? * blah blah blah
> ? ? ? ? */
>
>> + ? ? /* A new struct easycap is always allocated when interface 0 is probed.
>> + ? ? ?* It is not possible here to free any existing struct easycap.
>> + ? ? ?* This should have been done by easycap_delete() when the device was
>> + ? ? ?* physically unplugged.
>> + ? ? ?* The allocated struct easycap is saved for later usage when
>> + ? ? ?* interfaces 1 and 2 are probed.
>> + ? ? */
> ? ? ? ?^
> Could you make this asterisk line up with the others?

Of course.

If I send more patches about easycap driver, can I base it on my
current local branch?
I mean, based on all these patches?

Thanks,
Ezequiel.

           reply	other threads:[~2012-02-19 19:53 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20120218205121.GD2855@mwanda>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALF0-+VCb6S=kokeimO-+ophX+5tyvbv9Q6uSDxtsjXHLdKY8w@mail.gmail.com' \
    --to=elezegarcia@gmail.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).