From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1F5BC433EF for ; Fri, 17 Sep 2021 09:13:36 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C954611C3 for ; Fri, 17 Sep 2021 09:13:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4C954611C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mR9vc-0008LP-KV; Fri, 17 Sep 2021 05:13:04 -0400 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mR9vb-0008L9-G1 for kernelnewbies@kernelnewbies.org; Fri, 17 Sep 2021 05:13:03 -0400 Received: by mail-ot1-x32b.google.com with SMTP id 77-20020a9d0ed3000000b00546e10e6699so934964otj.2 for ; Fri, 17 Sep 2021 02:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=z4+cbTnfzH1tj/l8Tw2GfIK3WKW3qDHTFDBa9bCs+E0=; b=o5G+rXqUaiZ2ymAEmZkdcMPXh2zpbb64wE++GLNxQuTGfg6lWTHdyFqoSleY9QILJ3 RRq1DaOKXyguvLAKO3acrG7hUZrV3/zA+d3Pv0gdgV30+EfiYmYqDXC9wBebPgZ6der0 AlRWOXF0w4ciPOU63CYr5ckB+QYiWafT5UR180ycv99Ra7fHMQpepqiPotZvmdcpmBB4 8sM7hpur17nC7Bd46Z03WZHvtRMH7Nrzr97AGmy2KPylcs4Anm9DVXPwxOszjHjZX7W8 BEQrkKgHuDCLpWpoTDkGfyNejG7GFRNtPRHEamuzl/TTC8ZsErK30WWj99jjr6XNEi30 THMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=z4+cbTnfzH1tj/l8Tw2GfIK3WKW3qDHTFDBa9bCs+E0=; b=7D99UZDXr6o3Vok3mWCq1NeIqpD3Fqrd2gsNbZQuMaS0MG9ex49o+1Qb700W0/c0dc Rk3lyA668ZF5+7TsrfAYkhFmci6NuMnnieO0r7xwGxucdNgtKWQ7O5P0RmCodbxyeRFn E0bv8YPIfeapRu6OTaBAgBXrS3x8rGowb4t1P1l0qG0Xzf/3Psc9BMS+wIJRgmlbysfO cH51jxgYmOihPbcgmsz4fdThFg63tgIYw/yvB6hNXZYG4Zq0feroj4+RdJUD6Yh7KsS6 w+ogtRrz55p99T2fOUxTIMD8cncmmbFA/oYHl1DhfvBhmP8P+uQL7Uu8PLnT0xM4TpRj w8zA== X-Gm-Message-State: AOAM530bB3qFWAgMen4NGMX8ar2ix4TSgnWGWU9JKztrCCD2j5gfmx/y Vy53JHXbCLTH0LfZ65odOSAadRHnnnhGaGKFBPjqjx9XpJs= X-Google-Smtp-Source: ABdhPJwZR85o7Kufsvp07EW1xWqRBeyVrt5mr5IvrPjO56ZdBCS+ohkvv1H92tDO+wrnx7zANGmmalTKwW6NGzUDuhk= X-Received: by 2002:a05:6830:34f:: with SMTP id h15mr8670558ote.92.1631869982126; Fri, 17 Sep 2021 02:13:02 -0700 (PDT) MIME-Version: 1.0 From: FMDF Date: Fri, 17 Sep 2021 11:12:45 +0200 Message-ID: Subject: Commit messages in a series of patches To: kernelnewbies X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org Hi all, I've sent a series of 19 patches (co-developed by Pavel Skripkin). Now it is v7 and we hope it is the latest revision. :) Few days ago, when it was still at v5, Dan Carpenter reviewed the whole series and asked us to remove "irrelevant" information from the commit message of 15/19: [1] "This relates to the discussion we had about reviewing patches one at a time in the order they arrive. Every patch should be self contained. It should not refer to the past except in the case of explaining the Fixes tag and it should not refer to the future except in the case where it needs to excuse adding unused infrastructure. Reviewing is stateless. We don't want to know about your plans.". I decided that he was right and so I removed that extra information (they were about plans to remove the function that I'm cleaning up in the next patch 18/19. The clean-ups were somewhat necessary because part of the code of the old function is re-used in new functions introduced in 17/19 and 18/19 and it is then deleted forever, with a strange side effect that at least one reviewer (David Laight) thought that we were renaming variables and that renamings should go to separate patches. However they were _not_ renamings (as I explain above). I thought that preventive real renaming of the variables that I reuse in the next patches within _new_ functions would have helped other developers to review the patches 16-19/19 while avoiding that at a quick read they could appear as renaming. Actually then David wrote that now the patches are more easily readable. In the meantime, Dan C. granted his "Reviewed-by" tag to the first 14 patches of 19. All patches from 2/19 to 12/19 have the following phrase in the commit messages: "This patch is in preparation for the _io_ops structure removal.". [2] My question is: why "This patch is preparation for _io_ops [future] structure removal." is good while "Eventually this function will be deleted but some of the code will be reused later." is not. I'm not really interested in this specific case. I'd like to have general guidelines that I can understand and use for my future patches. Sorry for this long email, I wasn't able to make it shorter :( Thanks in advance to whoever has more experience than I have and wants to make this topic clearer to me. Fabio [1] https://lore.kernel.org/lkml/20210915135301.GF2088@kadam/ [2] https://lore.kernel.org/lkml/20210915124149.27543-3-fmdefrancesco@gmail.com/ _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies