struct definition inside a function

struct definition inside a function

[Anuz Pratap Singh Tomar]

[-- Attachment #1.1: Type: text/plain, Size: 332 bytes --]

Hi all,
I have not seen a struct define inside a function in kernel code and
couldn't find any guidelines if it's permitted or frowned upon?

int fn(int i)
{
 struct my_struct {
int var1;
int var2
}; /* is this allowed? */
struct my_struct struct_local;


return 0;
}
I'll appreciate any insight on this?
-- 
Thank you
Regards
Anuz

[-- Attachment #1.2: Type: text/html, Size: 663 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: struct definition inside a function

[Greg KH]

On Tue, Nov 29, 2022 at 03:06:30PM +0000, Anuz Pratap Singh Tomar wrote:
> Hi all,
> I have not seen a struct define inside a function in kernel code and
> couldn't find any guidelines if it's permitted or frowned upon?
> 
> int fn(int i)
> {
>  struct my_struct {
> int var1;
> int var2
> }; /* is this allowed? */
> struct my_struct struct_local;

Yes, it is allowed, but usually you never want to do that in a kernel
function as structures are normally used across functions, not just only
in a single one.

Do you have a real-world example where you feel this pattern is the
best?

thanks,

greg k-h

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies