From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 307C8C433ED for ; Mon, 26 Apr 2021 04:57:43 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 807A861263 for ; Mon, 26 Apr 2021 04:57:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 807A861263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94) (envelope-from ) id 1latJ1-0000i8-NJ; Mon, 26 Apr 2021 00:57:11 -0400 Received: from mail.kernel.org ([198.145.29.99]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1latIx-0000f9-Lo for kernelnewbies@kernelnewbies.org; Mon, 26 Apr 2021 00:57:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9E3C861360; Mon, 26 Apr 2021 04:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619413025; bh=oF5wTcVUbe3ITjsBTum2WMqyBNYZSs4s3HRFniDzF6I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gI1tY4u0dkEsqk7lL/9IJ+cSkvkBf7k+buPby21z5W+FJ88Et37I0dl4f3EPUDuY2 yUbkiFZeXThhswjtaYrhM3GhJZuhODBqpQ33pGgjIWsnRWU6BB0jDXATgA+ks7Rk/Q Pk6P+qxevkaCaY5eUpvP5PHH/RAtH2v+1pUqDXJ9ncyXzDS8dAG0V8UXyVscg6iblp Ed28Bx219ANuJYhPvfmhHL3V+WOU8tHXD4YwNmsBBKJSK/7r4WPO4YtPvjLmVi/G6k uTd7IDE1oVNhReVEKp/m8xpI7v30iRsQRMcsVimJOmXHSJGhQ1iMRvYlKPJAcknDRi HMlgwGB1eeCyA== Date: Mon, 26 Apr 2021 07:57:01 +0300 From: Leon Romanovsky To: Shuah Khan Subject: Re: [PATCH] drivers: pnp: proc.c: Removed unnecessary varibles Message-ID: References: <20210422180322.7wlyg63kv3n2k6id@ubuntu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Adam , kernelnewbies@kernelnewbies.org, Anupama K Patil , "Rafael J. Wysocki" , bkkarthik@pesu.pes.edu, linux-kernel@vger.kernel.org, Jaroslav Kysela , linux-acpi@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Fri, Apr 23, 2021 at 03:08:03PM -0600, Shuah Khan wrote: > On 4/22/21 12:03 PM, Anupama K Patil wrote: > > de, e are two variables of the type 'struct proc_dir_entry' > > which can be removed to save memory. This also fixes a coding style > > issue reported by checkpatch where we are suggested to make assignment > > outside the if statement. > > > > Sounds like a reasonable change. It is unclear how much changes to ISA code are welcomed. According to the Wikipedia, even Windows Vista disabled ISA PnP by default. https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications > > > Signed-off-by: Anupama K Patil > > --- > > drivers/pnp/isapnp/proc.c | 13 ++++++------- > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/pnp/isapnp/proc.c b/drivers/pnp/isapnp/proc.c > > index 785a796430fa..1ae458c02656 100644 > > --- a/drivers/pnp/isapnp/proc.c > > +++ b/drivers/pnp/isapnp/proc.c > > @@ -57,21 +57,20 @@ static const struct proc_ops isapnp_proc_bus_proc_ops = { > > static int isapnp_proc_attach_device(struct pnp_dev *dev) > > { > > struct pnp_card *bus = dev->card; > > - struct proc_dir_entry *de, *e; > > char name[16]; > > - if (!(de = bus->procdir)) { > > + if (!bus->procdir) { > > sprintf(name, "%02x", bus->number); > > It would make sense to change this to scnprintf() > > > - de = bus->procdir = proc_mkdir(name, isapnp_proc_bus_dir); > > - if (!de) > > + bus->procdir = proc_mkdir(name, isapnp_proc_bus_dir); > > + if (!bus->procdir) > > return -ENOMEM; > > } > > sprintf(name, "%02x", dev->number); > > It would make sense to change this to scnprintf() > > > - e = dev->procent = proc_create_data(name, S_IFREG | S_IRUGO, de, > > + dev->procent = proc_create_data(name, S_IFREG | S_IRUGO, bus->procdir, > > &isapnp_proc_bus_proc_ops, dev); > > - if (!e) > > + if (!dev->procent) > > return -ENOMEM; > > Shouldn't the procdir be deleted when proc_create_data() fails? It needs but only if proc_mkdir() was called in this function. Thanks > > > - proc_set_size(e, 256); > > + proc_set_size(dev->procent, 256); > > return 0; > > } > > > > Note that isapnp_proc_init() doesn't check isapnp_proc_attach_device() > return and handle errors and cleanup. > > thanks, > -- Shuah > > > > _______________________________________________ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies