From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E3C8C11F68 for ; Fri, 2 Jul 2021 12:20:32 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE6D061427 for ; Fri, 2 Jul 2021 12:20:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE6D061427 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1lzI9b-0005VH-Di; Fri, 02 Jul 2021 08:20:19 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lzI9X-0005VB-5o for kernelnewbies@kernelnewbies.org; Fri, 02 Jul 2021 08:20:15 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 711565C0163; Fri, 2 Jul 2021 08:20:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 02 Jul 2021 08:20:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=QubUKMVAG9lGj1Ehpm1o5Hmq/1L AaxgfRcq6HBYILCQ=; b=YevLIX2+Gk8caBD8Bfhjxxue79dFGJj3xSZBcZ8kx5O x57CTeBVoYv+KyNKRpsZ89PTinjuciaxfYk9NouvRKM+hc6O3FiUMnDw9d2n+Fnh o+9OTa8D2C4Sw9G9UNkEpVEpJC1BFT+BvdkpxU8NgEYMtW9iibEEPa3uqt2vuDkM ZPebfwW+K1qazFot7jw+XQVTvOQpqpV2m7SYzQ6HwqE9S7F1N0N6+ILuPWDOqgaF +VqfJ9uGXShVyeN+D/reBycW6vuVfHvNd7OF4sSuDKqW+H/IVLq0LnHfdXC9mHi7 1X2h/8TujPOnWHucnryIszAbW2A44FsqlCOwuspdkvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=QubUKM VAG9lGj1Ehpm1o5Hmq/1LAaxgfRcq6HBYILCQ=; b=mimYhhjpjdKPLVtx+Awhki zrDwmyp1zIf+BZ5ITV1tVkWci+vpZbWoshS3PHyZYLTks5oSUbjay88CVVwxc8Al J/6wV9M0bQqJMtYL1HN60FYWsJDtIZExdSSytb7gMjQFXJRsOkoDwB35mgNFodPn Hy1x3v+bJO+B8Wdeq/EIt5MMzVOtRXu46HjHABp4ch4noALf5Il1L2GxF0fhYxLp nHzB2DgGMd6VQc+RJU5DjURzd0NxPqta6UJOAhXn9jgfTLVFPI7teOY8y96aT0Ja vJV7n+DtEEe5aPFQIoy+nLTEYtWQPRKV0hgbvCne7ukwEVYIC5WwJpQ8NzSBL8yQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeeikedghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepifhrvghgucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheq necuggftrfgrthhtvghrnhepveeuheejgfffgfeivddukedvkedtleelleeghfeljeeiue eggeevueduudekvdetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Jul 2021 08:20:11 -0400 (EDT) Date: Fri, 2 Jul 2021 14:20:09 +0200 From: Greg KH To: Ian Pilcher Subject: Re: Seeking advice on "monkey patching" a driver Message-ID: References: <30faa352-0f60-10b9-887e-b2ee522d0a16@gmail.com> <5c34419f-ef7d-a9bd-0c90-c77e2526b739@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5c34419f-ef7d-a9bd-0c90-c77e2526b739@gmail.com> Cc: linux-modules@vger.kernel.org, kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Fri, Jul 02, 2021 at 07:05:26AM -0500, Ian Pilcher wrote: > > > I've invested significant time in kernel patches in the past, only to > > > see them ultimately not be accepted, so I would need to know that > > > upstream was truly interested in such a feature before I would consider > > > making such a commitment. > > > > That's not fair, there is no way anyone can promise anyone that their > > patches will be accepted, _before_ anyone sees them. What would _you_ > > do if you were in the kernel maintainer's position and read something > > like this? > > You're right, but that isn't what I intended to say. Basically, I can't > afford to invest the time in implementing something if the subsystem > maintainers have no interest in the *functionality*, regardless of the > state of the code. I.e., if the ATA/LED subsystem maintainers think > that software-controlled disk activity LEDs are stupid and have no > place in the kernel, then code quality is irrelevant, and anything I do > will be a waste of time. Again, without a real patch, no maintainer or developer will ever say if they will, or will not, accept such a thing. That's just not how kernel development works. Working patches are what is discussed as that proves that at least, the idea works. thanks, greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies