From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
kernelnewbies@kernelnewbies.org
Subject: Re: Linux driver of vt6656 from staging area causes system to freeze.
Date: Thu, 3 Feb 2022 09:54:53 +0100 [thread overview]
Message-ID: <YfuYXS23CNEf3nIN@kroah.com> (raw)
In-Reply-To: <fcc66cac-3074-9b13-f763-5b9edd52e8e5@gmail.com>
On Thu, Feb 03, 2022 at 01:41:11AM +0100, Philipp Hortmann wrote:
> I managed to get a device vt6656 (USB WiFi adapter). The device works OK
> when the computer is started and driver loaded. When the WLAN is disabled
> the system freezes often.
>
> I am using ubuntu 20.04 with kernel 5.17.0-rc1 x86_64
> branch: staging-testing
>
> After some tries I found out that it is a function in vnt_stop() main_usb.c
> with the following line that is causing this.
> usb_kill_urb(priv→interrupt_urb);
> But this memory is after this line still in use.
What "memory" do you mean?
> Digging deeper I found that the usb_submit_urb() function (in usbpipe.c
> vnt_start_interrupt_urb_complete) is called after the usb_kill_urb() is
> executed.
>
> So I tied the execution of the usb_submit_urb() to a flag called
> DEVICE_FLAGS_DISCONNECTED. After that no crashes were observed.
>
> So here my questions:
> - Is this the right place to fix?
Does it work for you? If so, let's try it.
> - Do I need to log a bug report before a patch?
Not at all. Please read the documention for how to submit a kernel
patch and we can take it from there. The patch looks sane, now just
submit it correctly and we can review it and maybe apply it from there.
thanks,
greg k-h
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2022-02-03 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 0:41 Linux driver of vt6656 from staging area causes system to freeze Philipp Hortmann
2022-02-03 8:54 ` Greg Kroah-Hartman [this message]
2022-02-03 19:19 ` Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfuYXS23CNEf3nIN@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=forest@alittletooquiet.net \
--cc=kernelnewbies@kernelnewbies.org \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox