From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B1A9C433EF for ; Tue, 7 Jun 2022 05:59:41 +0000 (UTC) Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nySFd-0006IW-GL; Tue, 07 Jun 2022 01:59:37 -0400 Received: from dfw.source.kernel.org ([139.178.84.217]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nySFb-0006IB-9A for kernelnewbies@kernelnewbies.org; Tue, 07 Jun 2022 01:59:35 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E56B06154E; Tue, 7 Jun 2022 05:59:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DF60C385A5; Tue, 7 Jun 2022 05:59:32 +0000 (UTC) Date: Tue, 7 Jun 2022 07:59:30 +0200 From: Greg KH To: ozzloy Subject: Re: request for feedback before sending this patch Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Mon, Jun 06, 2022 at 10:51:00PM -0700, ozzloy wrote: > i'd like to get some feedback before sending this off to the regular > mailing list. > i'm following Documentation/process/submitting-patches.rst and i think this > is OK, but i thought that before and was wrong. > > i'm not even sure if i should be asking here first, or sending this to the > list. > > are there any problems with the cleanup patch below? > it fixes something that checkpatch.pl lists as an error for pointer > location. > > ========================================================================= > >From 3ce7c7a3333aecaad6c28e0e1c17ce5b554274b0 Mon Sep 17 00:00:00 2001 > From: Daniel Watson > Date: Mon, 6 Jun 2022 11:31:31 -0700 > Subject: [PATCH] staging: r8188eu: fix declaration to match 'foo *bar' > > put '*' next to variable to match kernel style from checkpatch > > Signed-off-by: Daniel Watson > --- > drivers/staging/r8188eu/include/rtw_io.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/r8188eu/include/rtw_io.h > b/drivers/staging/r8188eu/include/rtw_io.h > index 6910e2b430e24..0e390eda5b4d3 100644 > --- a/drivers/staging/r8188eu/include/rtw_io.h > +++ b/drivers/staging/r8188eu/include/rtw_io.h > @@ -283,7 +283,7 @@ void free_io_queue(struct adapter *adapter); > void async_bus_io(struct io_queue *pio_q); > void bus_sync_io(struct io_queue *pio_q); > u32 _ioreq2rwmem(struct io_queue *pio_q); > -void dev_power_down(struct adapter * Adapter, u8 bpwrup); > +void dev_power_down(struct adapter *Adapter, u8 bpwrup); > > #define PlatformEFIOWrite1Byte(_a,_b,_c) \ > rtw_write8(_a,_b,_c) > -- > 2.34.1 Looks correct to me, send away! > ========================================================================= > > > > here's who i plan to send to: > Larry Finger > Phillip Potter > Greg Kroah-Hartman > linux-staging@lists.linux.dev Yes. > > should i include this list? > linux-kernel@vger.kernel.org If you really want to, sure. It's not required. > it is called a list of last resort here > https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html > but it is in the output of get-maintainer.pl for this patch. It's in the output of all runs of that tool, as you say, it's the last resort. good luck! greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies