How to resubmit patches in the right way after review fixes?

How to resubmit patches in the right way after review fixes?

[Adverg Ebashinskii]

[-- Attachment #1: Type: text/html, Size: 780 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: How to resubmit patches in the right way after review fixes?

[Greg KH]

On Sat, Aug 13, 2022 at 01:39:45AM +0300, Adverg Ebashinskii wrote:
> In case I have submitted a patch and some mistakes were pointed what is the
> right way of submitting a corrected version?
> I basically have 2 questions related to patch re-submit.
>  
> 1.  Is it appropriate to submit a new patch starting a new thread or it's
> required to reply
>     to one of the message in the old patch's thread to preserve a reference to
> the old one?

New thread is usually fine, but if you want you can do it in the old
thread, your choice.

> 2. In case the discussion of the patch ended up in patch redesign is it
> required to put a version when resubmitting?

Yes.

> For example the initial patch was [PATCH] sub/sys: summary. Should v2 be placed
> in the description of the new patch like
> [PATCH v2] sub/sys: completely different summary due to redesign?

Yes.  And properly document your changes below the --- line as the
documentation asks for.

hope this helps,

greg k-h

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies