From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD276C76196 for ; Tue, 28 Mar 2023 04:31:12 +0000 (UTC) Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.96) (envelope-from ) id 1ph0xf-0004jh-1p; Tue, 28 Mar 2023 00:29:31 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1ph0xb-0004jV-30 for kernelnewbies@kernelnewbies.org; Tue, 28 Mar 2023 00:29:30 -0400 Received: by mail-pj1-x102d.google.com with SMTP id o6-20020a17090a9f8600b0023f32869993so13946685pjp.1 for ; Mon, 27 Mar 2023 21:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679977759; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=+S16CUCVRAoMoq6gaH2frDd5Kmdad/W4shC4QeJprHg=; b=g6FiAZEVmK409L9mpx1XwR3CXf8uKlCpjQGNMoIPPIo0dx/dRwaY/MVCRk1b9Sb+Hj YB+hB54ZH6zhrh3EyT7hix+HEidLcmXHIuWnw7PBH6AA2tW3bej6JEWLYQ5Ql2CNutQo ME3YTfZ+RaB5XzbO4JFyQAmTodjQHoQAeMetMiFh2aByYDYbKrZp4M8sEysL02xd6D0U B76CTLtYTSFjexhISAOdV9+LPn2wFqWQHxvIMlUlOp4VxtxC3ktHH53udwoUXRjbwZKp a+gaUaNOwghaOwNR9ufa+3vBaJGwjSHi3Ks/HcOXo1sZqvhVyGt4UQ3oWr9N3jECx8Du RUpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679977759; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+S16CUCVRAoMoq6gaH2frDd5Kmdad/W4shC4QeJprHg=; b=yqycY9JJRmUCfyBd4gOsibOoIayc16RAxvgaMQUq2LtDh859UUPbY/30uaG0d8R31k Kvk3jS/69zvSgKYIsqak6vObyx4jiXMvx5lucI37Q8xSGJwtJBg9y8Ul4wav05l9b9Sx 02U9riKv4tkYOF2lfGdub4aQOiO6KXBxG0r5bV46X43gqVCh8RvPmKULUjPN2Ri5zLbW kx+sUAwFJYWA6C9UIdbqNUzXEJmEKVq6igpLKTUMNbbu0QkQoSYSBkMZonzBtWtex2dB o7IvWvREqZBsDrbzO8nbwczmH3zkl0oZ4bv7edLgiXUgZtB9rqgDDBIUDs/Nj80D+NNJ P/hQ== X-Gm-Message-State: AAQBX9eUoQloge8GK7rfJAZoB9YDgyRjot2fTduTCxKMIV2fBxyc3KAi OMBODccwdOT4dxmDON3si5LBO2+23AY= X-Google-Smtp-Source: AKy350ZiSvqyuNBW4CT5qzg/lUJ+BYOFtrnWIIlQgSDMXt0O4J1CGUD7V9J2JHE5I8ivHR405T8jlg== X-Received: by 2002:a17:903:22d2:b0:19c:dd49:9bf8 with SMTP id y18-20020a17090322d200b0019cdd499bf8mr20767209plg.28.1679977759328; Mon, 27 Mar 2023 21:29:19 -0700 (PDT) Received: from trent-reznor ([2601:641:4000:81:8acf:2c1e:2069:8f68]) by smtp.gmail.com with ESMTPSA id x15-20020a63f70f000000b0051303d3e3c5sm8981540pgh.42.2023.03.27.21.29.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 21:29:18 -0700 (PDT) Date: Mon, 27 Mar 2023 21:29:16 -0700 From: Daniel Watson To: kernelnewbies@kernelnewbies.org Subject: screening patch here before sending to devs Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org i am learning from guides like this https://kernelnewbies.org/FirstKernelPatch#FirstPatch i sent an earlier patch, but was told to skip the drivers/staging/media directory. is this an acceptable patch? is this message double-posting? it looks like my prior message shows up twice. thanks! To: Greg Kroah-Hartman ,linux-staging@lists.linux.dev,linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: move { onto opening line of if Checkpatch flagged this as a fixable style error. Signed-off-by: Daniel Watson --- drivers/staging/rtl8723bs/include/rtw_recv.h | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_recv.h b/drivers/staging/rtl8723bs/include/rtw_recv.h index 44f67103503ae..fef2fd0e8c84f 100644 --- a/drivers/staging/rtl8723bs/include/rtw_recv.h +++ b/drivers/staging/rtl8723bs/include/rtw_recv.h @@ -398,8 +398,7 @@ static inline u8 *recvframe_pull(union recv_frame *precvframe, signed int sz) precvframe->u.hdr.rx_data += sz; - if (precvframe->u.hdr.rx_data > precvframe->u.hdr.rx_tail) - { + if (precvframe->u.hdr.rx_data > precvframe->u.hdr.rx_tail) { precvframe->u.hdr.rx_data -= sz; return NULL; } @@ -425,8 +424,7 @@ static inline u8 *recvframe_put(union recv_frame *precvframe, signed int sz) precvframe->u.hdr.rx_tail += sz; - if (precvframe->u.hdr.rx_tail > precvframe->u.hdr.rx_end) - { + if (precvframe->u.hdr.rx_tail > precvframe->u.hdr.rx_end) { precvframe->u.hdr.rx_tail = prev_rx_tail; return NULL; } @@ -451,8 +449,7 @@ static inline u8 *recvframe_pull_tail(union recv_frame *precvframe, signed int s precvframe->u.hdr.rx_tail -= sz; - if (precvframe->u.hdr.rx_tail < precvframe->u.hdr.rx_data) - { + if (precvframe->u.hdr.rx_tail < precvframe->u.hdr.rx_data) { precvframe->u.hdr.rx_tail += sz; return NULL; } -- 2.34.1 _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies