From: Alison Schofield <alison.schofield@intel.com>
To: Anton Gusev <aagusev@ispras.ru>
Cc: kernelnewbies@kernelnewbies.org
Subject: Re: Need help determining if the change is warranted.
Date: Fri, 26 May 2023 17:36:59 -0700 [thread overview]
Message-ID: <ZHFQq4lv8WqjCH/f@aschofie-mobl2> (raw)
In-Reply-To: <6d8ba15e-254e-7b31-b3b8-cda9e6a2759b@ispras.ru>
This may be a resend. My first msg may be stuck in moderation,
because I sent w a new email addr.
On Mon, Mar 27, 2023 at 02:34:33PM +0300, Anton Gusev wrote:
> In the file drivers/leds/flash/leds-lm3601x.c, function lm3601x_strobe_set,
> the calls to regmap_update_bits aren't checked for errors.
>
> I am unsure whether adding the checks is warranted, since
> lm3601x_read_faults might cover the conditions that can cause
> regmap_update_bits to fail there. On the other hand, if this is not true,
> then lm3601x_strobe_set can fail silently. Also, all other calls to
> regmap_update_bit in the driver are checked or directly returned.
> --
> Anton Gusev
Hi Anton,
I don't see a patch posted for this, so I'll go ahead and respond.
It seems *something* can be improved here. Either examine those ret values
as they roll in, or stop assigning those ret values. Maybe, as you guess,
lm3601x_read_faults() is doing the needed checks. That's something you
could dig into further before posting the patch. Also, note the answer
might not be the same for all 3 of those calls.
Alison
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2023-05-27 0:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 11:34 Need help determining if the change is warranted Anton Gusev
2023-05-27 0:36 ` Alison Schofield [this message]
2023-05-27 6:05 ` Lucas Tanure
2023-05-28 4:18 ` Valdis Klētnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHFQq4lv8WqjCH/f@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=aagusev@ispras.ru \
--cc=kernelnewbies@kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox