From: Alison Schofield <alison.schofield@intel.com>
To: Torin Carey <torin@tcarey.uk>
Cc: Kernel Newbies <kernelnewbies@kernelnewbies.org>
Subject: Re: Existing patches of similar content
Date: Mon, 8 Sep 2025 14:48:27 -0700 [thread overview]
Message-ID: <aL9PK7fTu12zceWC@aschofie-mobl2.lan> (raw)
In-Reply-To: <KJvjv36__4DBpSNDDd16Pws7o2PRY2aysf3yUIDSekDcQZyl61bJbEYAPrMFlFI32cwc1Zd9fFPTGvI0G7fbT_-FSSgp1JVCglcBum7UZP8=@tcarey.uk>
On Sun, Sep 07, 2025 at 06:57:02PM +0000, Torin Carey wrote:
> Hi KernelNewbies,
>
> Apologies if this is a stupid question.
>
> I was finishing up on a patch to add a new (fairly small) feature to an existing driver. While looking at the archives for the relevant mailing list, I noticed another contributor had submitted a patch to add the exact same feature just under a year ago, but the thread seems to have gone stale. I believe there are some bits that were missing from this patch in terms of correctness.
>
> What's the usual etiquette to approach this situation? I could:
> 1. submit my patch for review anyway; or
> 2. resurrect this thread providing a review for it along with the additions I think might be necessary; or
> 3. a combination of both?
Kudo's to you for asking and for looking through the lore history of your
subsystem and finding the history of this feature.
There's a lot of variability in lore mailing lists, reviewers, and maintainers
responsiveness, so to be generic, I'll suggest your #2 option. Reply to the
patch, show what you'd like to change, and see what happens.
Maybe you breathe new life into it, the original author picks up your changes,
and the feature moves forward.
Maybe the original author acknowledges your changes and asks you to pick it up
and carry it forward.
Maybe crickets, in which case you can submit a new patch, probably with a tag
'Originally-by:' or 'Co-developed-by'.
BTW if you do pick it up, make sure to address any concerns raised with the
original patch.
Good Luck,
Alison
>
> ---
> Torin
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2025-09-08 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 18:57 Existing patches of similar content Torin Carey
2025-09-08 21:48 ` Alison Schofield [this message]
2025-09-15 12:41 ` Torin Carey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aL9PK7fTu12zceWC@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=kernelnewbies@kernelnewbies.org \
--cc=torin@tcarey.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox