kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: rpjday@crashcourse.ca (Robert P. J. Day)
To: kernelnewbies@lists.kernelnewbies.org
Subject: A quick guide to why stand-alone checkpatch patches suck...
Date: Wed, 17 Sep 2014 08:00:39 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.11.1409170758340.4859@localhost> (raw)
In-Reply-To: <28d9b586-092c-4f91-8488-5bb8acc81851@email.android.com>

On Wed, 17 Sep 2014, Greg Freemyer wrote:

>
>
> On September 17, 2014 7:20:42 AM EDT, "Robert P. J. Day" <rpjday@crashcourse.ca> wrote:
> <snip>
> >
> >  and, as we've all seen, nick's other flaw is that, quite simply,
> >he's selfish and greedy. his entire obsession is with the output of
> >checkpatch, which means he wants to grab all the trivial cleanup (the
> >low-hanging fruit, as it were) for himself, and not leave any for
> >others. rather than take the time to understand the code, nick wants
> >checkpatch to do all the work for him. in the end, nick doesn't want
> >to do any work or understand how the kernel actually works -- he just
> >wants patches, and he wants them as quickly and cheaply as possible.
>
> Nick and his patches may have plenty of flaws, but I think it is a
> bit crazy to call his effort to get his first patch into the kernel
> greedy.

  i was actually referring to nick's more recent posting where he
vowed to use his patch as the template to start cleaning up all of
drivers/staging/. i thought i was fairly clear that there is nothing
wrong with *starting* with stylistic cleanup, but nick made it quite
clear he planned on doing this all over drivers/staging. *that* is
what i was referring to.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

  reply	other threads:[~2014-09-17 12:00 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17  0:25 A quick guide to why stand-alone checkpatch patches suck Valdis Kletnieks
2014-09-17  0:37 ` Greg KH
2014-09-17  1:35 ` Greg Donald
2014-09-17  3:42   ` Valdis.Kletnieks at vt.edu
2014-09-17  4:56     ` Greg KH
2014-09-17  5:43       ` Sudip Mukherjee
2014-09-17 10:39       ` Robert P. J. Day
2014-09-17 11:20       ` Robert P. J. Day
2014-09-17 11:38         ` nick
2014-09-17 11:51           ` Sudip Mukherjee
2014-09-17 11:53             ` nick
2014-09-17 12:05               ` Greg Freemyer
2014-09-17 12:09                 ` nick
2014-09-17 12:17                   ` Kai Bojens
2014-09-17 12:23                     ` nick
2014-09-17 12:25                   ` Greg Freemyer
2014-09-17 12:29                     ` Nick Krause
2014-09-17 14:39                   ` Valdis.Kletnieks at vt.edu
2014-09-17 11:53           ` Robert P. J. Day
2014-09-17 11:55             ` nick
2014-09-17 12:17               ` Chris Lee
2014-09-17 12:19                 ` nick
2014-09-17 11:56         ` Greg Freemyer
2014-09-17 12:00           ` Robert P. J. Day [this message]
2014-09-17 12:05             ` nick
2014-09-17 12:02           ` nick
2014-09-17 14:39             ` Valdis.Kletnieks at vt.edu
2014-09-17 17:04               ` Nick Krause
2014-09-17 17:13               ` Bruno Guedes Souto
2014-09-17 17:47                 ` Nick Krause
2014-09-17 18:01                   ` Philipp Muhoray
2014-09-17 18:14                     ` Nick Krause
2014-09-17 18:15                   ` Robert P. J. Day
2014-09-17 18:44                     ` Nick Krause
2014-09-17 20:45                 ` John de la Garza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.11.1409170758340.4859@localhost \
    --to=rpjday@crashcourse.ca \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).