From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82885C4338F for ; Tue, 10 Aug 2021 16:44:02 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1366C60EDF for ; Tue, 10 Aug 2021 16:44:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1366C60EDF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mDUr8-0006tw-6G; Tue, 10 Aug 2021 12:43:58 -0400 Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mDUr5-0006te-Hn for kernelnewbies@kernelnewbies.org; Tue, 10 Aug 2021 12:43:55 -0400 Received: by mail-ot1-x331.google.com with SMTP id c2-20020a0568303482b029048bcf4c6bd9so22666141otu.8 for ; Tue, 10 Aug 2021 09:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QhOtPuefuEMutGsCac+f7EFLsvx2tEnekhhvoDt/lTU=; b=p3zrQvymLKbekm91ddwjWDFOReJMaIdqA40ppej9m6Dddym4prDrExG+jHtC+kRlb0 zOwO8/fG+hehzgCCqoLI6DhnRBGBh30eAcg8xqqhwGPHVXtLQM8RdJBzu4Q0taaJ8bHd XKSrZr4BxvmtsZAMmIEntsZDMw23qP9cLucGQmSFU4vIZ9GWUXr/GNurRsQTjhVFD0BU DSgO5xiE9oAqvUgiJr8eJZHudcLHFTjwkyMIJqIRjqTn2xOUwI1c91spza2OH9Ctv7Gp u3T8FTaKEC0Dil+cudVsRyqVj+a0rEqh9cdmRhU82HimdP7xU5E9nK1QCzn2ByJU8WBw U0yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QhOtPuefuEMutGsCac+f7EFLsvx2tEnekhhvoDt/lTU=; b=GnegfgPcyo1pHVIVa6pTnwoA3wtWdeZ2nip6+1YAGbNTYI9XWt5Tqk9aNLMlPPAXRq GlNEnMk1I+N1Mm9DxjZ3Puk3BsS10lRxTKVm2hpfdLqbDvWqxIAjPP404JIFkY1d80Jk 9tJiZ4fPEmO8bF/e+VYld9cQvKH/DPhTCSPTmmJzKh9Q3BlTaNXONa+QTnaLthlyBzYi eYX16Wdi150Q678/SgZGN24u4ef8grghn7RmLcdQLX1NLVfSFctu268RuG6P0f+BQ0zk aI7Hf/zigjHFPFdFzFKDfHBlbRDnmQ46eLHo87j5a+VVN3/mT/rNcC9qtLqAKrmkqJ9U zryQ== X-Gm-Message-State: AOAM530SW2D4pQDL0gAT/+VoF45oyL2o8dCk6FCJdzQm3ar2EHbyu6Ke Ya3kKCGQ2BskVnCpwNpQs54= X-Google-Smtp-Source: ABdhPJwPiOzwiIW+6zBsXx6aoG+opP1d+hflXb52aJ5eawnb3ZjsavNTzWtFQply3xj7O1lZ1Udgvw== X-Received: by 2002:a9d:61cc:: with SMTP id h12mr15104495otk.190.1628613833977; Tue, 10 Aug 2021 09:43:53 -0700 (PDT) Received: from ian.penurio.us ([47.184.51.90]) by smtp.gmail.com with ESMTPSA id r25sm3410110oos.24.2021.08.10.09.43.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Aug 2021 09:43:53 -0700 (PDT) Subject: Re: [RFC PATCH v2 00/10] Add configurable block device LED triggers To: Greg KH References: <20210809033217.1113444-1-arequipeno@gmail.com> <20210809205633.4300bbea@thinkpad> <81c128a1-c1b8-0f1e-a77b-6704bade26c0@gmail.com> <20210810004331.0f0094a5@thinkpad> <7b5f3509-5bcd-388b-8d3b-4ea95a9483ad@gmail.com> <20210810153840.42419d06@thinkpad> From: Ian Pilcher Message-ID: Date: Tue, 10 Aug 2021 11:43:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , axboe@kernel.dk, kernelnewbies@kernelnewbies.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, pavel@ucw.cz, pali@kernel.org, hch@lst.de, linux-leds@vger.kernel.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kernelnewbies-bounces@kernelnewbies.org On 8/10/21 11:24 AM, Greg KH wrote: > There should not be anything "odd" about block devices here, just do > whatever all other LED drivers do when referencing a device. AFAIK, the only LED trigger that does anything similar is the netdev trigger. It uses dev_get_by_name(), which is specific to network devices. The block subsystem doesn't appear to have any similar API, which is why Enzo submitted his patch to export block_class and disk_type back in April[1], when he wanted to do something similar. I'm basically bypassing the need to export the symbols, because my trigger code is actually in the block subsystem, rather than the LEDs subsystem. [1] https://www.spinics.net/lists/linux-leds/msg18244.html -- ======================================================================== In Soviet Russia, Google searches you! ======================================================================== _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies