From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9592C11F68 for ; Fri, 2 Jul 2021 15:17:09 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DC8061416 for ; Fri, 2 Jul 2021 15:17:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DC8061416 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1lzKuQ-0005EJ-Bu; Fri, 02 Jul 2021 11:16:50 -0400 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1lzKuN-0005EB-6Z for kernelnewbies@kernelnewbies.org; Fri, 02 Jul 2021 11:16:47 -0400 Received: by mail-ot1-x32a.google.com with SMTP id 59-20020a9d0ac10000b0290462f0ab0800so10335336otq.11 for ; Fri, 02 Jul 2021 08:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=B9EIAtqvJkd6e9xc3VesLciiUAHcDoNUbTx9mbowXis=; b=gUfyTN2euikHY1wpgr4MTO9j3ohm9e2s9pEkm7FFKC6JwuJsNq2g8Q/QlaM67ayEyJ f2Fzynt6onQxr1EmimTCXdxAmb2MLxY3jo1pKc/NCL1SXlAzECWpUmgBamFNfxjpNHi+ 3WIZd3BAh5qpWHJlBjR+eigy3wBLjCSo5yfAZW1KJGIZEoINqtreGIBGDJFcARfEKXNe Y9k0forkp9h68HTlG22ILSiqU5YOMpDiMZrpJHDy1U+foBu46Mw5zvI3KFGQaKnr54UE rjBTuzVZug13JiI0IRzT2HUYngtiVX0s80ri4rbKcePE883WFqDAPWooLlzp340E2qJ4 LvOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=B9EIAtqvJkd6e9xc3VesLciiUAHcDoNUbTx9mbowXis=; b=hiJvpG9Rcn+kHcPlUCX1o7Xh6eP+bJdXfjQCf2DK1CsgH7kTxRBmYzwhoPkjQfdceF xwsfxsdrnUuYDg921Kr6xvEq++LJeu5X8uiU51Gs5A/AUV4CU5iUOVnYTGX+laMD6jLg VmXriPKq3mNuyfsFJTZJntCfKS+yojGI6eRrKpS1sKYJ7or5Ncl+ArMkqs5SPvTO0ktM SU6o8jmWtHzVsQ9KGKAr80/oFk4QV72r4vczKcf/xBTE4KsIVVI/D3w5DyYwrlQqCUs8 8R/bUMi4Xg3LdGlYsyn5I8kvrcTni+oMYMqzceaIgwLUf8XzWCPSAQnFN8HSaYokVHkj ti+A== X-Gm-Message-State: AOAM5335iosQUOkULh2F0lsQq8F2s0ASeuND/1jpxYwc6DKpt/wLbqxl hbfLNB0TlpWxswEEJJfQ52b8L908VlA= X-Google-Smtp-Source: ABdhPJwtF3LBAMoM3qmqU6fLIEOjjCjY2ljXDLrZLubsJWzkZvPW8/fK7eUwF8wTR6xhaSlER6IYpA== X-Received: by 2002:a05:6830:224e:: with SMTP id t14mr1557203otd.69.1625239005615; Fri, 02 Jul 2021 08:16:45 -0700 (PDT) Received: from ian.penurio.us ([47.184.51.90]) by smtp.gmail.com with ESMTPSA id c4sm673008ots.15.2021.07.02.08.16.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jul 2021 08:16:44 -0700 (PDT) Subject: Re: Seeking advice on "monkey patching" a driver To: Greg KH References: <30faa352-0f60-10b9-887e-b2ee522d0a16@gmail.com> <5c34419f-ef7d-a9bd-0c90-c77e2526b739@gmail.com> From: Ian Pilcher Message-ID: Date: Fri, 2 Jul 2021 10:16:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: linux-modules@vger.kernel.org, kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kernelnewbies-bounces@kernelnewbies.org On 7/2/21 7:20 AM, Greg KH wrote: > Again, without a real patch, no maintainer or developer will ever say if > they will, or will not, accept such a thing. That's just not how kernel > development works. Working patches are what is discussed as that proves > that at least, the idea works. And that's certainly their prerogative. You asked why I hadn't attempted to submit changes upstream to address my issue, and I provided my reasons for not doing so. After several experiences where I've invested a significant (to me) amount of time, only to ultimately be told that the functionality that I implemented really wasn't desired, I'm very reluctant to repeat that experience (and I honestly don't think that's particularly selfish or unreasonable). This doesn't mean that I absolutely won't make an attempt to do this. As I mentioned in my previous note, the existence of ledtrig-disk.c gives me some hope that changes might be accepted. I'll just have to see ... -- ======================================================================== In Soviet Russia, Google searches you! ======================================================================== _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies