From: Dave Hansen <dave.hansen@intel.com>
To: David Woodhouse <dwmw2@infradead.org>,
Rohan Kakulawaram <rohanka@google.com>,
kexec <kexec@lists.infradead.org>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
David Woodhouse <dwmw@amazon.co.uk>,
Kai Huang <kai.huang@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Uros Bizjak <ubizjak@gmail.com>,
Sohil Mehta <sohil.mehta@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] x86/kexec: Push kjump return address even for non-kjump kexec
Date: Thu, 7 May 2026 15:08:08 -0700 [thread overview]
Message-ID: <01a9f690-11d4-41c6-a884-18958b4566cd@intel.com> (raw)
In-Reply-To: <32d627134143ffd957891cb697138e839c623211.camel@infradead.org>
On 4/28/26 13:59, David Woodhouse wrote:
> + /*
> + * Set return address to 0 if not preserving context. The purgatory
> + * shipped in kexec-tools will unconditionally look for the return
> + * address on the stack and set a kexec_jump_back_entry= command
> + * line option if it's non-zero. There's no other way that it can
> + * tell a preserve-context (kjump) kexec from a normal one.
> + */
> + pushq $0
Thanks for the update. LGTM:
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
prev parent reply other threads:[~2026-05-07 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 20:59 [PATCH v2] x86/kexec: Push kjump return address even for non-kjump kexec David Woodhouse
2026-05-07 22:08 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01a9f690-11d4-41c6-a884-18958b4566cd@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=dwmw@amazon.co.uk \
--cc=hpa@zytor.com \
--cc=kai.huang@intel.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rohanka@google.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@kernel.org \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox