Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: James Morse <james.morse@arm.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>, sashal@kernel.org
Cc: mark.rutland@arm.com, vladimir.murzin@arm.com, corbet@lwn.net,
	catalin.marinas@arm.com, bhsharma@redhat.com,
	steve.capper@arm.com, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, jmorris@namei.org,
	linux-mm@kvack.org, rfontana@redhat.com, ebiederm@xmission.com,
	maz@kernel.org, matthias.bgg@gmail.com, tglx@linutronix.de,
	will@kernel.org, selindag@gmail.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 12/18] arm64: kexec: arm64_relocate_new_kernel don't use x0 as temp
Date: Thu, 7 May 2020 17:22:20 +0100	[thread overview]
Message-ID: <04f091b1-692d-c204-8a65-9048fb8b5a5e@arm.com> (raw)
In-Reply-To: <20200326032420.27220-13-pasha.tatashin@soleen.com>

Hi Pavel,

On 26/03/2020 03:24, Pavel Tatashin wrote:
> x0 will contain the only argument to arm64_relocate_new_kernel; don't
> use it as a temp. Reassigned registers to free-up x0.

The missing bit of motivation is _why_ you need x0 keep its value until the end of this code.

With that covered,
Reviewed-by: James Morse <james.morse@arm.com>


Thanks,

James

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2020-05-07 16:22 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200326032420.27220-1-pasha.tatashin@soleen.com>
     [not found] ` <20200326032420.27220-2-pasha.tatashin@soleen.com>
2020-04-29 17:00   ` [PATCH v9 01/18] arm64: kexec: make dtb_mem always enabled James Morse
2021-01-23  0:17     ` Pavel Tatashin
     [not found] ` <20200326032420.27220-3-pasha.tatashin@soleen.com>
2020-04-29 17:00   ` [PATCH v9 02/18] arm64: hibernate: move page handling function to new trans_pgd.c James Morse
2021-01-23  0:18     ` Pavel Tatashin
     [not found] ` <20200326032420.27220-4-pasha.tatashin@soleen.com>
2020-04-29 17:01   ` [PATCH v9 03/18] arm64: trans_pgd: make trans_pgd_map_page generic James Morse
2021-01-22 21:52     ` Pavel Tatashin
     [not found] ` <20200326032420.27220-5-pasha.tatashin@soleen.com>
2020-04-29 17:01   ` [PATCH v9 04/18] arm64: trans_pgd: pass allocator trans_pgd_create_copy James Morse
2021-01-23  0:20     ` Pavel Tatashin
     [not found] ` <20200326032420.27220-6-pasha.tatashin@soleen.com>
2020-04-29 17:01   ` [PATCH v9 05/18] arm64: trans_pgd: pass NULL instead of init_mm to *_populate functions James Morse
2021-01-23  0:22     ` Pavel Tatashin
     [not found] ` <20200326032420.27220-8-pasha.tatashin@soleen.com>
2020-04-29 17:01   ` [PATCH v9 07/18] arm64: trans_pgd: hibernate: idmap the single page that holds the copy page routines James Morse
2021-01-23  0:35     ` Pavel Tatashin
     [not found] ` <20200326032420.27220-9-pasha.tatashin@soleen.com>
2020-04-29 17:01   ` [PATCH v9 08/18] arm64: kexec: move relocation function setup James Morse
2021-01-23  1:01     ` Pavel Tatashin
     [not found] ` <20200326032420.27220-10-pasha.tatashin@soleen.com>
2020-04-29 17:01   ` [PATCH v9 09/18] arm64: kexec: call kexec_image_info only once James Morse
     [not found] ` <20200326032420.27220-11-pasha.tatashin@soleen.com>
2020-04-29 17:01   ` [PATCH v9 10/18] arm64: kexec: cpu_soft_restart change argument types James Morse
2021-01-23  1:14     ` Pavel Tatashin
     [not found] ` <20200326032420.27220-16-pasha.tatashin@soleen.com>
2020-04-29 17:35   ` [PATCH v9 15/18] arm64: kexec: kexec EL2 vectors Marc Zyngier
2021-01-25 19:07     ` Pavel Tatashin
2020-05-07 16:21   ` James Morse
     [not found] ` <20200326032420.27220-12-pasha.tatashin@soleen.com>
2020-05-07 16:22   ` [PATCH v9 11/18] arm64: kexec: arm64_relocate_new_kernel clean-ups James Morse
     [not found] ` <20200326032420.27220-14-pasha.tatashin@soleen.com>
2020-05-07 16:22   ` [PATCH v9 13/18] arm64: kexec: add expandable argument to relocation function James Morse
2021-01-23  2:49     ` Pavel Tatashin
     [not found] ` <20200326032420.27220-13-pasha.tatashin@soleen.com>
2020-05-07 16:22   ` James Morse [this message]
     [not found] ` <20200326032420.27220-15-pasha.tatashin@soleen.com>
2020-05-07 16:22   ` [PATCH v9 14/18] arm64: kexec: offset for " James Morse
     [not found] ` <20200326032420.27220-17-pasha.tatashin@soleen.com>
2020-05-07 16:22   ` [PATCH v9 16/18] arm64: kexec: configure trans_pgd page table for kexec James Morse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04f091b1-692d-c204-8a65-9048fb8b5a5e@arm.com \
    --to=james.morse@arm.com \
    --cc=bhsharma@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=ebiederm@xmission.com \
    --cc=jmorris@namei.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=maz@kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=rfontana@redhat.com \
    --cc=sashal@kernel.org \
    --cc=selindag@gmail.com \
    --cc=steve.capper@arm.com \
    --cc=tglx@linutronix.de \
    --cc=vladimir.murzin@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox