From: Eric DeVolder <eric.devolder@oracle.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, ebiederm@xmission.com,
dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com,
tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, hpa@zytor.com,
nramas@linux.microsoft.com, thomas.lendacky@amd.com,
robh@kernel.org, efault@gmx.de, rppt@kernel.org,
david@redhat.com, sourabhjain@linux.ibm.com,
konrad.wilk@oracle.com, boris.ostrovsky@oracle.com
Subject: Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support
Date: Wed, 2 Nov 2022 09:55:06 -0500 [thread overview]
Message-ID: <06ef6e4b-1f42-d50f-1328-4f82fb34dd4d@oracle.com> (raw)
In-Reply-To: <Y2I3zQ9ZU+C9Kgf7@zn.tnic>
On 11/2/22 04:26, Borislav Petkov wrote:
> On Tue, Nov 01, 2022 at 10:45:00AM -0500, Eric DeVolder wrote:
>> As I'm re-reading that message, I suspect now the preference is to just to
>> strike this ifdiffery line in this file and have the code always present?
>>
>> If the preference is actually for CRASH_HOTPLUG, then let me know.
>
> Well, it is this part:
>
> "But on a plain simple laptop or workstation which has CPU hotplug,
> would it make sense for the crash ranges to get updated too when CPUs
> are offlined?
Yes, it does.
>
> If so, I think you want this code present there too, without a Kconfig
> item."
Ah, ok.
>
> IOW, if this thing doesn't make sense to have on the majority of
> machines out there - and memory hotplug machines are not the majority -
> then it should be behind a Kconfig item which is default off and gets
> enabled only when the user selects crash and memory hotplug...
>
> I'd say.
>
Ok, I'll will remove the ifdef line/pair.
Thanks!
eric
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2022-11-02 14:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 19:35 [PATCH v13 0/7] crash: Kernel handling of CPU and memory hot un/plug Eric DeVolder
2022-10-31 19:35 ` [PATCH v13 1/7] crash: move crash_prepare_elf64_headers() Eric DeVolder
2022-10-31 19:35 ` [PATCH v13 2/7] crash: prototype change for crash_prepare_elf64_headers() Eric DeVolder
2022-10-31 19:36 ` [PATCH v13 3/7] crash: add generic infrastructure for crash hotplug support Eric DeVolder
2022-10-31 19:36 ` [PATCH v13 4/7] kexec: exclude elfcorehdr from the segment digest Eric DeVolder
2022-10-31 19:36 ` [PATCH v13 5/7] kexec: exclude hot remove cpu from elfcorehdr notes Eric DeVolder
2022-10-31 19:36 ` [PATCH v13 6/7] crash: memory and cpu hotplug sysfs attributes Eric DeVolder
2022-10-31 19:36 ` [PATCH v13 7/7] x86/crash: add x86 crash hotplug support Eric DeVolder
2022-10-31 21:04 ` Borislav Petkov
2022-11-01 15:45 ` Eric DeVolder
2022-11-02 9:26 ` Borislav Petkov
2022-11-02 14:55 ` Eric DeVolder [this message]
2022-11-02 16:19 ` Borislav Petkov
2022-11-02 16:54 ` Eric DeVolder
2022-11-02 18:49 ` Borislav Petkov
2022-11-02 18:57 ` Eric DeVolder
2022-11-02 19:22 ` Borislav Petkov
2022-11-09 15:48 ` Eric DeVolder
2022-11-09 21:31 ` Borislav Petkov
2022-11-09 22:12 ` Eric DeVolder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06ef6e4b-1f42-d50f-1328-4f82fb34dd4d@oracle.com \
--to=eric.devolder@oracle.com \
--cc=bhe@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nramas@linux.microsoft.com \
--cc=robh@kernel.org \
--cc=rppt@kernel.org \
--cc=sourabhjain@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox