Re: [RFC PATCH 6/7] x86/kexec: Debugging support: Dump registers on exception

From: David Woodhouse <dwmw2@infradead.org>
To: "H. Peter Anvin" <hpa@zytor.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	 "jpoimboe@kernel.org" <jpoimboe@kernel.org>
Cc: "horms@kernel.org" <horms@kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,  "bp@alien8.de" <bp@alien8.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"kai.huang@intel.com" <kai.huang@intel.com>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kirill.shutemov@linux.intel.com"
	<kirill.shutemov@linux.intel.com>,
	"nik.borisov@suse.com" <nik.borisov@suse.com>,
	 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re:  [RFC PATCH 6/7] x86/kexec: Debugging support: Dump registers on exception
Date: Tue, 05 Nov 2024 13:29:54 -0800	[thread overview]
Message-ID: <07117fe234cb1396a59bdb815ada26a90e02b394.camel@infradead.org> (raw)
In-Reply-To: <66DC35BB-A9E5-45E4-AAAD-051C22943F51@zytor.com>

[-- Attachment #1.1: Type: text/plain, Size: 2541 bytes --]

On Tue, 2024-11-05 at 12:50 -0800, H. Peter Anvin wrote:
> On November 5, 2024 12:38:10 PM PST, "Woodhouse, David" <dwmw@amazon.co.uk> wrote:
> > On Sun, 2024-11-03 at 05:35 +0000, David Woodhouse wrote:
> > > 
> > > +
> > > +/* Print the byte in %bl, clobber %rax */
> > > +SYM_CODE_START_LOCAL_NOALIGN(pr_byte)
> > > +       movb    %bl, %al
> > > +       nop
> > > +       andb    $0x0f, %al
> > > +       addb    $0x30, %al
> > > +       cmpb    $0x3a, %al
> > > +       jb      1f
> > > +       addb    $('a' - '0' - 10), %al
> > > +1:     pr_char
> > > +       ANNOTATE_UNRET_SAFE
> > > +       ret
> > > +SYM_CODE_END(pr_byte)
> > > +
> > 
> > Obviously that function name (and comment) are wrong; fixed in my tree.
> > at
> > https://git.infradead.org/users/dwmw2/linux.git/shortlog/refs/heads/kexec-debug
> > 
> > This function (and also pr_qword) are also what objtool is complaining
> > about:
> > 
> > vmlinux.o: warning: objtool: relocate_range+0x2f6: unreachable instruction
> > vmlinux.o: warning: objtool: relocate_range+0x305: unreachable instruction
> > 
> > I don't quite see why, because pr_qword() quite blatantly calls
> > pr_nyblle(), as it's now named. And exc_handler() repeatedly calls
> > pr_qword().
> > 
> > But most of the objtool annotations I've added here were just to make
> > it shut up and build, without much though. Peter, Josh, any chance you
> > can help me fix it up please?
> > 
> > It would also be really useful if objtool would let me have data inside
> > a "code" segment, without complaining that it can't decode it as
> > instructions — and without also failing to decode the first instruction
> > of the *subsequent* function. I've put the GDT at the end to work
> > around that, but it's a bit nasty.
> 
> code in the data *section* or *segment*? Either is nasty, though. That's what .rodata is for.

This is the relocate_kernel() function in
arch/x86/kernel/relocate_kernel_64.S

It's copied into a separate page, called (in its original location) as
a simple function from the kernel, changes %cr3 to set of identity-
mapped page tables and jumps to its *identity-mapped* address, then
copies all the right pages for kexec and jumps into the new kernel.

So it's all in a single page, and currently it plays nasty tricks to
store data after the code. Perhaps it *should* have its own code and
data sections and a linker script to keep them together...

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]

[-- Attachment #2: Type: text/plain, Size: 143 bytes --]

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec