From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pf0-f170.google.com ([209.85.192.170]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dDPfs-0003Pg-I1 for kexec@lists.infradead.org; Wed, 24 May 2017 06:21:38 +0000 Received: by mail-pf0-f170.google.com with SMTP id m17so134167094pfg.3 for ; Tue, 23 May 2017 23:21:15 -0700 (PDT) Subject: Re: [PATCH 2/2] Revert "[PATCH V2 1/4] x86_64: Calculate page_offset from pt_load" References: <33710E6CAA200E4583255F4FB666C4E20D205C05@G01JPEXMBYT03> <681cf021-74c0-25d2-a173-23ba50c38cab@redhat.com> <449aaa2b-0058-8b4d-227b-df97256b5674@redhat.com> <33710E6CAA200E4583255F4FB666C4E20D2060C9@G01JPEXMBYT03> <33710E6CAA200E4583255F4FB666C4E20D21B9BC@G01JPEXMBYT03> <7e95a840-2982-90bd-69fc-fe6f55caa0a0@redhat.com> From: Pratyush Anand Message-ID: <07bb2312-6a8a-b7dd-451e-1ae4a0d726aa@redhat.com> Date: Wed, 24 May 2017 11:51:10 +0530 MIME-Version: 1.0 In-Reply-To: <7e95a840-2982-90bd-69fc-fe6f55caa0a0@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed"; DelSp="yes" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: "Hatayama, Daisuke" Cc: "'ats-kumagai@wm.jp.nec.com'" , "'kexec@lists.infradead.org'" , "'bhe@redhat.com'" On Wednesday 24 May 2017 11:13 AM, Pratyush Anand wrote: > Hi Hatayama, > > > On Wednesday 24 May 2017 07:39 AM, Hatayama, Daisuke wrote: >> How about this? >> - return immediately in case of kaslr because there's no need to refer to >> PT_LOAD entries, >> - refer to PT_LOAD entries only if they exist, and >> - finally try to get page offset according to kernel versions. > > It looks fine to me. > So if you agree then I can send next revision with your "Suggested-by" tag. > > https://github.com/pratyushanand/makedumpfile/commit/16655ce1f4c2da8d4066072db2a03c84bf2553fe return TRUEin case of KASLR success was missing in above. Fixed that. https://github.com/pratyushanand/makedumpfile/commit/e13807fc6391bf71e7822d39cdb084d3bf481818 ~Pratyush _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec