From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Simon Horman <horms@kernel.org>
Cc: kexec@lists.infradead.org, linux-doc@vger.kernel.org,
bhe@redhat.com, corbet@lwn.net, kernel@gpiccoli.net,
linux-kernel@vger.kernel.org, stephen.s.brennan@oracle.com,
kernel-dev@igalia.com, dyoung@redhat.com, vgoyal@redhat.com,
linux-debuggers@vger.kernel.org
Subject: Re: [PATCH V2] Documentation: Improve crash_kexec_post_notifiers description
Date: Wed, 11 Sep 2024 17:10:25 +0200 [thread overview]
Message-ID: <121b62a7-bd2d-0ded-97a7-ac890831ca63@igalia.com> (raw)
In-Reply-To: <20240902082342.GC23170@kernel.org>
On 02/09/2024 10:23, Simon Horman wrote:
>
> Hi Guilherme,
>
> Some subjective grammar nits.
>
>> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
>> index efc52ddc6864..351730108c58 100644
>> --- a/Documentation/admin-guide/kernel-parameters.txt
>> +++ b/Documentation/admin-guide/kernel-parameters.txt
>> @@ -913,12 +913,16 @@
>> the parameter has no effect.
>>
>> crash_kexec_post_notifiers
>> - Run kdump after running panic-notifiers and dumping
>> - kmsg. This only for the users who doubt kdump always
>> - succeeds in any situation.
>> - Note that this also increases risks of kdump failure,
>> - because some panic notifiers can make the crashed
>> - kernel more unstable.
>> + Only jump to kdump kernel after running the panic
>> + notifiers and dumping kmsg. This option increases the
>> + risks of a kdump failure, since some panic notifiers
>> + can make the crashed kernel more unstable. In the
>
> nit: In the configurations -> In configurations
>
>> + configurations where kdump may not be reliable,
>> + running the panic notifiers can allow collecting more
>> + data on dmesg, like stack traces from other CPUS or
>> + extra data dumped by panic_print. Notice that some
>
> nit: Notice that -> Note that
>
>> + code enables this option unconditionally, like
>
> Maybe: some code enables -> some configurations enable
>
Hey Simon, tnx for the suggestions, will change in the next version.
Cheers,
Guilherme
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2024-09-11 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 18:21 [PATCH V2] Documentation: Improve crash_kexec_post_notifiers description Guilherme G. Piccoli
2024-09-02 3:05 ` Baoquan He
2024-09-11 15:09 ` Guilherme G. Piccoli
2024-09-12 0:54 ` Baoquan He
2024-09-02 8:23 ` Simon Horman
2024-09-11 15:10 ` Guilherme G. Piccoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=121b62a7-bd2d-0ded-97a7-ac890831ca63@igalia.com \
--to=gpiccoli@igalia.com \
--cc=bhe@redhat.com \
--cc=corbet@lwn.net \
--cc=dyoung@redhat.com \
--cc=horms@kernel.org \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=kexec@lists.infradead.org \
--cc=linux-debuggers@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephen.s.brennan@oracle.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox