Re: [PATCH 15/15] Revert "x86: default to reboot via ACPI"

Len Brown
2008-11-07T02:03:17Z

On Fri, 7 Nov 2008, Matthew Garrett wrote:

> On Thu, Nov 06, 2008 at 07:30:43PM -0600, Robert Hancock wrote:
>
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8fd145917fb62368a9b80db59562c20576238f5a
> >
> > This patch ignores the RESET_REG_SUP flag and just tries using the reset
> > register anyway if it thinks it's valid. So we may attempt ACPI reset on
> > machines which don't indicate it's supported.
>
> Yeah, that sounds very wrong.

As it turns out, it was an incorrect guess on our part on how to be "bug
compatible" and I'm reverting it per the regression report here:

http://bugzilla.kernel.org/show_bug.cgi?id=11942

-Len

> > The patch description mentioned that some machines didn't reboot after
> > S3 suspend without this patch. However, we recently had this patch merged:
> >
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a68823ee5285e65b51ceb96f8b13a5b4f99a6888
> >
> > Is it possible that the problem fixed there is the true cause of this
> > reboot after S3 problem?
>
> Oh, yeah, could be. Given the From:, I should really have thought of
> that :)
>
> --
> Matthew Garrett | mjg59@srcf.ucam.org