From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from gate.crashing.org ([63.228.1.57]) by canuck.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1Q2cEy-0005AH-59 for kexec@lists.infradead.org; Thu, 24 Mar 2011 04:33:45 +0000 Subject: Re: [PATCH 1/2] kdump: Allow shrinking of kdump region to be overridden From: Benjamin Herrenschmidt In-Reply-To: References: <20100825002258.GD28360@kryten> <4D771EE6.5050404@linux.vnet.ibm.com> <20110309122046.GC16951@cr0.redhat.com> <20110309234657.264d3080@kryten> <20110309142108.GD16951@cr0.redhat.com> <20110314181315.GA16075@in.ibm.com> <20110315165219.GA22509@in.ibm.com> Date: Thu, 24 Mar 2011 15:33:30 +1100 Message-ID: <1300941210.2402.414.camel@pasglop> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: "Eric W. Biederman" Cc: linuxppc-dev@ozlabs.org, Anton Blanchard , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, WANG Cong On Mon, 2011-03-21 at 03:10 +0000, WANG Cong wrote: > On Tue, 15 Mar 2011 22:22:19 +0530, Mahesh J Salgaonkar wrote: > >> Okay, but with this patch applied, we will just ignore rtas region, > >> right? > > Correct. > >> Thus, when I echo 0 to free all the 128M crashkernel memory, the final > >> result will be 32M left, which means crash_size will still show 32M. > >> This looks odd. > >> > >> How about skipping the 32M as a whole? I mean once the region being > >> freed has overlap with this rtas region, skip the whole rtas region, > >> and let crash_size > >> show 0? > > The existing code from crash_shrink_memory() function reduces the crash > > size to 0 when echo'ed 0. I did test this patchset and verified that > > /sys/kernel/kexec_crash_size show 0 value. > > Oh, ok. > > Acked-by: WANG Cong So Eric, what's the right approach to get that merged ? This is a bug gating an important delivery for us, and the patch doesn't appear terribly invasive ? :-) I can send it to Linus myself if you prefer and give me your Ack. Cheers, Ben. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec