From: WANG Chao <chaowang@redhat.com>
To: horms@verge.net.au
Cc: kexec@lists.infradead.org
Subject: [PATCH] kexec: Replace printf() with die() to error out to stderr
Date: Tue, 14 May 2013 11:56:48 +0800 [thread overview]
Message-ID: <1368503808-16601-1-git-send-email-chaowang@redhat.com> (raw)
Error messages are mixed stderr with stdout when we use die() along with
printf(). So use die() to keep error out consistent.
Signed-off-by: WANG Chao <chaowang@redhat.com>
---
kexec/kexec.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/kexec/kexec.c b/kexec/kexec.c
index 53d6edc..911c0f6 100644
--- a/kexec/kexec.c
+++ b/kexec/kexec.c
@@ -1176,17 +1176,17 @@ int main(int argc, char *argv[])
}
if ((kexec_flags & KEXEC_ON_CRASH) && !is_crashkernel_mem_reserved()) {
- printf("Memory for crashkernel is not reserved\n");
- printf("Please reserve memory by passing ");
- printf("\"crashkernel=X@Y\" parameter to the kernel\n");
- die("Then try loading kdump kernel\n");
+ die("Memory for crashkernel is not reserved\n"
+ "Please reserve memory by passing"
+ "\"crashkernel=X@Y\" parameter to kernel\n"
+ "Then try to loading kdump kernel\n");
}
if (do_load && (kexec_flags & KEXEC_PRESERVE_CONTEXT) &&
mem_max == ULONG_MAX) {
- printf("Please specify memory range used by kexeced kernel\n");
- printf("to preserve the context of original kernel with \n");
- die("\"--mem-max\" parameter\n");
+ die("Please specify memory range used by kexeced kernel\n"
+ "to preserve the context of original kernel with \n"
+ "\"--mem-max\" parameter\n");
}
fileind = optind;
--
1.8.2.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2013-05-14 3:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 3:56 WANG Chao [this message]
2013-05-14 4:35 ` [PATCH] kexec: Replace printf() with die() to error out to stderr Zhang Yanfei
2013-05-14 4:35 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368503808-16601-1-git-send-email-chaowang@redhat.com \
--to=chaowang@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox