From: Daniel Kiper <daniel.kiper@oracle.com>
To: kumagai-atsushi@mxc.nes.nec.co.jp, kexec@lists.infradead.org,
xen-devel@lists.xensource.com
Cc: Daniel Kiper <daniel.kiper@oracle.com>
Subject: [PATCH 2/7] elf: Increase buf size in get_pt_note_info()
Date: Fri, 12 Jul 2013 15:48:10 +0200 [thread overview]
Message-ID: <1373636895-31682-3-git-send-email-daniel.kiper@oracle.com> (raw)
In-Reply-To: <1373636895-31682-1-git-send-email-daniel.kiper@oracle.com>
get_pt_note_info() always ignores VMCOREINFO_XEN note
because buf size is too small. It does not have place
for \0 char which marks EOS. This patch fixes that bug
and VMCOREINFO_XEN note living in /proc/vmcore file
could be properly detected now.
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
elf_info.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/elf_info.c b/elf_info.c
index 0c1e36a..70a6dd2 100644
--- a/elf_info.c
+++ b/elf_info.c
@@ -310,7 +310,7 @@ get_pt_note_info(void)
{
int n_type, size_name, size_desc;
off_t offset, offset_desc;
- char buf[VMCOREINFO_XEN_NOTE_NAME_BYTES];
+ char buf[VMCOREINFO_XEN_NOTE_NAME_BYTES + 1];
char note[MAX_SIZE_NHDR];
nr_cpus = 0;
--
1.7.10.4
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-07-12 13:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 13:48 [PATCH 0/7] Xen fixes and minor cleanups Daniel Kiper
2013-07-12 13:48 ` [PATCH 1/7] xen: Improve calculation of beginning of virtual address space Daniel Kiper
2013-07-12 13:48 ` Daniel Kiper [this message]
2013-07-12 14:04 ` [Xen-devel] [PATCH 2/7] elf: Increase buf size in get_pt_note_info() Andrew Cooper
2013-07-12 19:09 ` Daniel Kiper
2013-07-12 13:48 ` [PATCH 3/7] xen: Take into account new frame table address since Xen 4.3 Daniel Kiper
2013-07-12 13:48 ` [PATCH 4/7] xen: Enforce page size only when xen-syms file is used Daniel Kiper
2013-07-12 13:48 ` [PATCH 5/7] Mute some compiler warnings Daniel Kiper
2013-07-12 14:12 ` [Xen-devel] " Andrew Cooper
2013-07-12 13:48 ` [PATCH 6/7] Use elf_getshdrstrndx() instead of elf_getshstrndx() Daniel Kiper
2013-07-12 13:48 ` [PATCH 7/7] Do not break progress messages Daniel Kiper
2013-07-12 14:01 ` [Xen-devel] [PATCH 0/7] Xen fixes and minor cleanups Andrew Cooper
2013-07-12 14:30 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373636895-31682-3-git-send-email-daniel.kiper@oracle.com \
--to=daniel.kiper@oracle.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox