Re: [PATCH v2 6/7] Mute some compiler warnings

Atsushi Kumagai
2013-07-19T09:22:37Z

On Tue, 16 Jul 2013 14:32:08 +0200
Daniel Kiper <daniel.kiper@oracle.com> wrote:

> This patch mutes follwing compiler warnings:
> - warning: assignment discards ‘const’ qualifier from
> pointer target type [enabled by default],
> - warning: variable ‘page_offset’ set but not used
> [-Wunused-but-set-variable].
>
> v2 - suggestions/fixes:
> - do not discard a const qualifier
> (suggested by Andrew Cooper).
>
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>

Good, I'll merge this patch into v1.5.5.
And thanks for your review, HATAYAMA-san.

Thanks
Atsushi Kumagai

On Fri, 19 Jul 2013 09:03:49 +0900
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> wrote:

> (2013/07/16 21:32), Daniel Kiper wrote:
> <cut>
> > diff --git a/sadump_info.c b/sadump_info.c
> > index be6cf55..01cf5eb 100644
> > --- a/sadump_info.c
> > +++ b/sadump_info.c
> > @@ -948,7 +948,6 @@ int
> > readpage_sadump(unsigned long long paddr, void *bufptr)
> > {
> > unsigned long long pfn, block, whole_offset, perdisk_offset;
> > - ulong page_offset;
> > int fd_memory;
> >
> > if (si->kdump_backed_up &&
> > @@ -957,7 +956,6 @@ readpage_sadump(unsigned long long paddr, void *bufptr)
> > paddr += si->backup_offset - si->backup_src_start;
> >
> > pfn = paddr_to_pfn(paddr);
> > - page_offset = paddr % info->page_size;
> >
> > if (pfn >= si->sh_memory->max_mapnr)
> > return FALSE;
> >
>
> It seems good to me. Thanks.