From: Joe Perches <joe@perches.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org,
Eric Biederman <ebiederm@xmission.com>
Subject: Re: [PATCH 1/3] kexec: Add debug printing of kimage table entries
Date: Tue, 15 Oct 2013 10:58:15 -0700 [thread overview]
Message-ID: <1381859895.22110.30.camel@joe-AO722> (raw)
In-Reply-To: <1381859307-11932-2-git-send-email-geert@linux-m68k.org>
On Tue, 2013-10-15 at 19:48 +0200, Geert Uytterhoeven wrote:
> Print a list of pages to be copied if debugging is enabled.
> Consecutive entries are merged to reduce screen clutter.
[]
> diff --git a/kernel/kexec.c b/kernel/kexec.c
[]
> +static void kimage_print_block(const struct kimage_block *block)
> +{
> + pr_info("Copy from 0x%lx-0x%lx to 0x%lx-0x%lx (0x%lx bytes)\n",
> + block->src, block->src + block->len - 1, block->dst,
> + block->dst + block->len - 1, block->len);
> +}
Perhaps pr_debug and this maybe nicer to read like:
pr_debug("kimage: Copy from 0x%lx-0x%lx to 0x%lx-0x%lx (0x%lx bytes)\n",
block->src, block->src + block->len - 1,
block->dst, block->dst + block->len - 1,
block->len);
Using a "kimage: " prefix could help grep too.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-10-15 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 17:48 [PATCH v2] kexec support for Linux/m68k (kernel part) Geert Uytterhoeven
2013-10-15 17:48 ` [PATCH 1/3] kexec: Add debug printing of kimage table entries Geert Uytterhoeven
2013-10-15 17:58 ` Joe Perches [this message]
2013-10-15 19:25 ` Eric W. Biederman
2013-10-15 20:03 ` Geert Uytterhoeven
2013-10-15 17:48 ` [PATCH 2/3] m68k: Add kexec support Geert Uytterhoeven
2013-10-15 17:48 ` [PATCH 3/3] m68k: Add support to export bootinfo in procfs Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381859895.22110.30.camel@joe-AO722 \
--to=joe@perches.com \
--cc=ebiederm@xmission.com \
--cc=geert@linux-m68k.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox