From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VnUJU-0006WT-KY for kexec@lists.infradead.org; Mon, 02 Dec 2013 14:17:29 +0000 From: Daniel Kiper Subject: [PATCH v2 2/4] makedumpfile/xen: Disable cyclic mode for every Xen crash dump Date: Mon, 2 Dec 2013 15:16:42 +0100 Message-Id: <1385993804-27721-3-git-send-email-daniel.kiper@oracle.com> In-Reply-To: <1385993804-27721-1-git-send-email-daniel.kiper@oracle.com> References: <1385993804-27721-1-git-send-email-daniel.kiper@oracle.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: andrew.cooper3@citrix.com, david.vrabel@citrix.com, kumagai-atsushi@mxc.nes.nec.co.jp, kexec@lists.infradead.org, xen-devel@lists.xen.org Cc: Daniel Kiper Disable cyclic mode for every Xen crash dump not only when -X option is used. This way makedumpfile is much more flexible and different modes could be used to dump whole system memory (e.g. zero pages could be striped without requiring -X option). Signed-off-by: Daniel Kiper --- makedumpfile.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/makedumpfile.c b/makedumpfile.c index 55e53b7..5a378d1 100644 --- a/makedumpfile.c +++ b/makedumpfile.c @@ -2928,20 +2928,20 @@ initial(void) } #endif - if (info->flag_exclude_xen_dom) { + if (is_xen_memory()) { if(info->flag_cyclic) { info->flag_cyclic = FALSE; MSG("Switched running mode from cyclic to non-cyclic,\n"); MSG("because the cyclic mode doesn't support Xen.\n"); } + } - if (!is_xen_memory()) { - MSG("'-X' option is disable,"); - MSG("because %s is not Xen's memory core image.\n", info->name_memory); - MSG("Commandline parameter is invalid.\n"); - MSG("Try `makedumpfile --help' for more information.\n"); - return FALSE; - } + if (info->flag_exclude_xen_dom && !is_xen_memory()) { + MSG("'-X' option is disable,"); + MSG("because %s is not Xen's memory core image.\n", info->name_memory); + MSG("Commandline parameter is invalid.\n"); + MSG("Try `makedumpfile --help' for more information.\n"); + return FALSE; } if (info->flag_refiltering) { -- 1.7.10.4 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec