From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ea0-f180.google.com ([209.85.215.180]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W2f3o-0002wn-ID for kexec@lists.infradead.org; Mon, 13 Jan 2014 10:48:01 +0000 Received: by mail-ea0-f180.google.com with SMTP id f15so3225564eak.11 for ; Mon, 13 Jan 2014 02:47:37 -0800 (PST) From: Taras Kondratyuk Subject: [RESEND PATCH] kexec: arm: Fix endianness in crashdump header Date: Mon, 13 Jan 2014 12:47:25 +0200 Message-Id: <1389610045-5372-1-git-send-email-kondratyuk.taras@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Simon Horman Cc: Taras Kondratiuk , kexec@lists.infradead.org, patches@linaro.org From: Taras Kondratiuk Currently little-endian ELFDATA is hard-coded in crashdump header. This lead to a wrong header format if crashdump is generated on BE system. Set native endianness into ELFDATA field. Signed-off-by: Taras Kondratiuk --- Based on commit 027413d "kexec: Add m68k support" kexec/arch/arm/crashdump-arm.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/kexec/arch/arm/crashdump-arm.c b/kexec/arch/arm/crashdump-arm.c index 01973b1..0cd6935 100644 --- a/kexec/arch/arm/crashdump-arm.c +++ b/kexec/arch/arm/crashdump-arm.c @@ -31,6 +31,13 @@ #include "../../crashdump.h" #include "crashdump-arm.h" +#if __BYTE_ORDER == __LITTLE_ENDIAN +#define ELFDATANATIVE ELFDATA2LSB +#elif __BYTE_ORDER == __BIG_ENDIAN +#define ELFDATANATIVE ELFDATA2MSB +#else +#error "Unknown machine endian" +#endif /* * Used to save various memory ranges/regions needed for the captured @@ -47,7 +54,7 @@ static struct memory_range crash_reserved_mem; static struct crash_elf_info elf_info = { .class = ELFCLASS32, - .data = ELFDATA2LSB, + .data = ELFDATANATIVE, .machine = EM_ARM, .page_offset = PAGE_OFFSET, }; -- 1.7.9.5 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec