From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XBgBo-0005J9-IG for kexec@lists.infradead.org; Mon, 28 Jul 2014 08:21:49 +0000 From: Baoquan He Subject: [Patch v3 1/7] initialize pfn_memhole in get_num_dumpable_cyclic Date: Mon, 28 Jul 2014 16:20:00 +0800 Message-Id: <1406535606-16303-2-git-send-email-bhe@redhat.com> In-Reply-To: <1406535606-16303-1-git-send-email-bhe@redhat.com> References: <1406535606-16303-1-git-send-email-bhe@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: kexec@lists.infradead.org Cc: kumagai-atsushi@mxc.nes.nec.co.jp, Baoquan He , vgoyal@redhat.com This is a code bug. In initialize_2nd_bitmap_cyclic pfn_memhole is calculated, however it's not initialized before that. If an available pfn_memhole is wanted after get_num_dumpable_cyclic invocation, initializing pfn_memhole in get_num_dumpable_cyclic is necessary. Signed-off-by: Baoquan He --- makedumpfile.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/makedumpfile.c b/makedumpfile.c index 3884aa5..760bfd1 100644 --- a/makedumpfile.c +++ b/makedumpfile.c @@ -5588,6 +5588,8 @@ get_num_dumpable_cyclic(void) mdf_pfn_t pfn, num_dumpable=0; struct cycle cycle = {0}; + pfn_memhole = info->max_mapnr; + for_each_cycle(0, info->max_mapnr, &cycle) { if (!exclude_unnecessary_pages_cyclic(&cycle)) -- 1.8.5.3 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec