From: Harshula Jayasuriya <harshula@redhat.com>
To: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
Cc: Minoru Usui <usui@mxm.nes.nec.co.jp>,
Masaki Tachibana <tachibana@mxm.nes.nec.co.jp>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH] makedumpfile.8: "cache without private" column of the table for -d appears to be incorrect
Date: Fri, 17 Oct 2014 12:49:00 +1100 [thread overview]
Message-ID: <1413510540.514.175.camel@serendib> (raw)
In-Reply-To: <0910DD04CBD6DE4193FCF86B9C00BE9701D564D0@BPXM01GP.gisp.nec.co.jp>
Hi,
On Fri, 2014-10-17 at 01:02 +0000, Atsushi Kumagai wrote:
> Hello,
>
> >Hi,
> >
> >The makedumpfile man page contains a table explaining the usage of -d.
> >The "cache without private" column implies that -d 4 would exclude "cache
> >without private" pages. However, a -d 4 should only exclude "cache with
> >private".
>
> "cache with private" includes "cache without private" because the latter
> doesn't mean leaving private cache pages, just mean excluding cache pages
> except private pages. Meanwhile, "cache with private" means excluding both
> cache pages (private and non-private). So "with private" meets "without private"
> in this feature, they aren't exclusive.
> This style is for diskdump compatibility, but now I suspect it may be
> bit confusing.
Ahhh I see! ;-)
> I don't want to change the behavior of the page filtering, but I guess
> changing the column names might be meaningful.
Would the following help?
a) s/cache without private/non-private cache/
b) s/cache with private/all cache/
cya,
#
> I'm curious to know what everyone thought of the two columns. This can
> be a good opportunity to make the manual easier to understand.
>
>
> Thanks,
> Atsushi Kumagai
>
> >makedumpfile.h:
> >------------------------------------------------------------
> > #define DL_EXCLUDE_CACHE (0x002) /* Exclude Cache Pages
> > without Private Pages */
> >------------------------------------------------------------
> >
> >makedumpfile.8:
> >------------------------------------------------------------
> > | |cache |cache | |
> > dump | zero |without|with | user | free
> > level | page |private|private| data | page
> > -------+------+-------+-------+------+------
> > 0 | | | | |
> > 1 | X | | | |
> > 2 | | X | | |
> > 3 | X | X | | |
> > 4 | | X | X | |
> > 5 | X | X | X | |
> > 6 | | X | X | |
> > 7 | X | X | X | |
> > 8 | | | | X |
> >------------------------------------------------------------
> >
> >Signed-off-by: Harshula Jayasuriya <harshula@redhat.com>
> >---
> > makedumpfile.8 | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> >diff --git a/makedumpfile.8 b/makedumpfile.8
> >index 9cb12c0..382c6ee 100644
> >--- a/makedumpfile.8
> >+++ b/makedumpfile.8
> >@@ -174,32 +174,32 @@ by dump_level 11, makedumpfile retries it by dump_level 31.
> > 1 | X | | | |
> > 2 | | X | | |
> > 3 | X | X | | |
> >- 4 | | X | X | |
> >- 5 | X | X | X | |
> >+ 4 | | | X | |
> >+ 5 | X | | X | |
> > 6 | | X | X | |
> > 7 | X | X | X | |
> > 8 | | | | X |
> > 9 | X | | | X |
> > 10 | | X | | X |
> > 11 | X | X | | X |
> >- 12 | | X | X | X |
> >- 13 | X | X | X | X |
> >+ 12 | | | X | X |
> >+ 13 | X | | X | X |
> > 14 | | X | X | X |
> > 15 | X | X | X | X |
> > 16 | | | | | X
> > 17 | X | | | | X
> > 18 | | X | | | X
> > 19 | X | X | | | X
> >- 20 | | X | X | | X
> >- 21 | X | X | X | | X
> >+ 20 | | | X | | X
> >+ 21 | X | | X | | X
> > 22 | | X | X | | X
> > 23 | X | X | X | | X
> > 24 | | | | X | X
> > 25 | X | | | X | X
> > 26 | | X | | X | X
> > 27 | X | X | | X | X
> >- 28 | | X | X | X | X
> >- 29 | X | X | X | X | X
> >+ 28 | | | X | X | X
> >+ 29 | X | | X | X | X
> > 30 | | X | X | X | X
> > 31 | X | X | X | X | X
> >
> >--
> >1.9.3
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2014-10-17 1:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 6:45 [PATCH] makedumpfile.8: "cache without private" column of the table for -d appears to be incorrect Harshula Jayasuriya
2014-10-17 1:02 ` Atsushi Kumagai
2014-10-17 1:49 ` Harshula Jayasuriya [this message]
2014-10-17 7:37 ` Atsushi Kumagai
2014-10-24 2:45 ` Harshula Jayasuriya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413510540.514.175.camel@serendib \
--to=harshula@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=tachibana@mxm.nes.nec.co.jp \
--cc=usui@mxm.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox