From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y5yFV-00013m-3f for kexec@lists.infradead.org; Tue, 30 Dec 2014 14:58:17 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBUEvs9q027432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 30 Dec 2014 09:57:54 -0500 From: Prarit Bhargava Subject: [PATCH] kexec, remove panic_on_warn kernel parameter from kdump situations Date: Tue, 30 Dec 2014 09:57:51 -0500 Message-Id: <1419951471-19765-1-git-send-email-prarit@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: kexec@lists.infradead.org Cc: Prarit Bhargava , Dave Young , WANG Chao , Vivek Goyal panic_on_warn kernel parameter will cause the kernel to panic when a WARN() is hit in the kernel. This is not a good situation for the kdump kernel because then it would be possible for the kdump kernel to panic in a non-fatal WARN(). This patch removes panic_on_warn as a kernel parameter for the kdump kernel. Signed-off-by: Prarit Bhargava Cc: Dave Young Cc: Vivek Goyal Cc: WANG Chao --- kexec/kexec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kexec/kexec.c b/kexec/kexec.c index b088916..323cafb 100644 --- a/kexec/kexec.c +++ b/kexec/kexec.c @@ -1048,8 +1048,10 @@ char *get_command_line(void) line[strlen(line) - 1] = '\0'; remove_parameter(line, "BOOT_IMAGE"); - if (kexec_flags & KEXEC_ON_CRASH) + if (kexec_flags & KEXEC_ON_CRASH) { remove_parameter(line, "crashkernel"); + remove_parameter(line, "panic_on_warn"); + } return line; } -- 1.7.9.3 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec